Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "mode" option to cfg file #28

Merged
merged 3 commits into from Aug 9, 2019
Merged

Conversation

@AlAlves
Copy link
Contributor

@AlAlves AlAlves commented Aug 5, 2019

Add a "mode" option on .cfg file to define whether you are going for a bmc or an induction proof

Add a "mode" option on .cfg file to define whether you are going for a bmc or an induction proof
@cliffordwolf
Copy link
Collaborator

@cliffordwolf cliffordwolf commented Aug 7, 2019

The formal test-bench used by riscv-formal (rvfi_testbench) only activates the checker in cycle RISCV_FORMAL_CHECK_CYCLE. Thus, changing the SBY mode from bmc to prove will not change what is proven.

Thus for a complete proof rvfi_testbench must be changed so that trig and check are unconstrained, for example by connecting them primary inputs of rvfi_testbench. A new configuration variable, for example RISCV_FORMAL_UNBOUNDED, should control this.

Copy link
Collaborator

@cliffordwolf cliffordwolf left a comment

@@ -433,6 +446,7 @@ def check_cons(check, chanidx=None, start=None, trig=None, depth=None, csr_mode=
check_cons("unique", chanidx=i, start=0, trig=1, depth=2)
check_cons("causal", chanidx=i, start=0, depth=1)
check_cons("ill", chanidx=i, depth=0)
check_cons("const_2_time", chanidx=i, start=0, trig=1, depth=2)

This comment has been minimized.

@cliffordwolf

cliffordwolf Aug 8, 2019
Collaborator

What is const_2_time?

This comment has been minimized.

@AlAlves

AlAlves Aug 8, 2019
Author Contributor

Oops, my bad, I mixed this version with my custom version.

I fixed it.

@cliffordwolf cliffordwolf merged commit f239761 into SymbioticEDA:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants