Add support for optionally ignoring rmask #37
Closed
Conversation
|
That should not be necessary. Simply set rmaks to all-bits-set. As long as you correctly provide the data for all bits in rdata everything should work just fine. See the mem_rmask checks in rvfi_insn_check.sv: they only require that the core sets at least the required bits in rmask. It's always correct to read more bytes from memory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Some cores do not have read mask support for memory accesses, this PR makes it possible to handle them.