Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optionally ignoring rmask #37

Closed
wants to merge 1 commit into from

Conversation

@chgentso
Copy link

@chgentso chgentso commented Apr 14, 2020

Some cores do not have read mask support for memory accesses, this PR makes it possible to handle them.

@cliffordwolf
Copy link
Collaborator

@cliffordwolf cliffordwolf commented Apr 22, 2020

That should not be necessary. Simply set rmaks to all-bits-set. As long as you correctly provide the data for all bits in rdata everything should work just fine.

See the mem_rmask checks in rvfi_insn_check.sv: they only require that the core sets at least the required bits in rmask. It's always correct to read more bytes from memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants