Fix some syntax errors #45

leonschoorl · 2021-01-26T19:52:10Z

I tried to follow the Quick Start Guide, but I ran into some syntax errors with the current version of yosys (8eaeaa84346):

[pc_fwd_ch0] base: rvfi_pc_fwd_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[causal_ch0] base: rvfi_causal_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[liveness_ch0] base: rvfi_liveness_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[reg_ch0] base: rvfi_reg_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[unique_ch0] base: rvfi_unique_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[pc_bwd_ch0] base: rvfi_pc_bwd_check.sv:19: ERROR: syntax error, unexpected TOK_RAND
[csrw_mcycle_ch0] base: rvfi_csrw_check.sv:56: ERROR: syntax error, unexpected TOK_ID
[csrw_minstret_ch0] base: rvfi_csrw_check.sv:56: ERROR: syntax error, unexpected TOK_ID

After these patches I'm still left with the same PREUNSAT errors as #36.

The current Yosys only accepts the order: rand const The other way round results in: ERROR: syntax error, unexpected TOK_RAND And "rand const" is also the way they show it in their README: https://github.com/YosysHQ/yosys/blob/master/README.md#non-standard-or-systemverilog-features-for-formal-verification

So it matches the new order of the modifiers

`csrget(`RISCV_FORMAL_CSRW_NAME, rmask) Got expanded into: rvfi.csr_mcycle_ rmask Because of the extra space, this resulted in: [csrw_mcycle_ch0] base: rvfi_csrw_check.sv:56: ERROR: syntax error, unexpected TOK_ID

leonschoorl added 3 commits Jan 26, 2021

Rename macro rvformal_const_rand_reg to rvformal_rand_const_reg

0a29531

So it matches the new order of the modifiers

Fix syntax errors in rvfi_csrw_check.sv

e0fd8ce

`csrget(`RISCV_FORMAL_CSRW_NAME, rmask) Got expanded into: rvfi.csr_mcycle_ rmask Because of the extra space, this resulted in: [csrw_mcycle_ch0] base: rvfi_csrw_check.sv:56: ERROR: syntax error, unexpected TOK_ID

SymbioticEDA / riscv-formal

Fix some syntax errors #45

Fix some syntax errors #45

leonschoorl commented Jan 26, 2021

SymbioticEDA / riscv-formal

Fix some syntax errors #45

Fix some syntax errors #45

Conversation

leonschoorl commented Jan 26, 2021