Skip to content

fix: mutation error for Zygote #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

fix: mutation error for Zygote #130

merged 1 commit into from
Jun 14, 2025

Conversation

MilesCranmer
Copy link
Member

No description provided.

@MilesCranmer MilesCranmer enabled auto-merge June 14, 2025 19:56
Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master cd69d8d... master / cd69d8d...
eval/ComplexF32/evaluation 7.32 ± 0.58 ms 7.25 ± 0.63 ms 1.01 ± 0.12
eval/ComplexF64/evaluation 10.8 ± 0.83 ms 10.8 ± 0.98 ms 1 ± 0.12
eval/Float32/derivative 11.7 ± 0.59 ms 11.6 ± 0.56 ms 1.01 ± 0.07
eval/Float32/derivative_turbo 11.8 ± 0.62 ms 11.6 ± 0.5 ms 1.02 ± 0.07
eval/Float32/evaluation 2.72 ± 0.29 ms 2.73 ± 0.27 ms 0.995 ± 0.14
eval/Float32/evaluation_bumper 0.566 ± 0.016 ms 0.567 ± 0.015 ms 0.998 ± 0.039
eval/Float32/evaluation_turbo 0.518 ± 0.029 ms 0.519 ± 0.028 ms 0.998 ± 0.078
eval/Float32/evaluation_turbo_bumper 0.567 ± 0.016 ms 0.568 ± 0.016 ms 0.999 ± 0.039
eval/Float64/derivative 15 ± 1.1 ms 14.9 ± 0.88 ms 1 ± 0.097
eval/Float64/derivative_turbo 14.8 ± 1.1 ms 14.9 ± 0.98 ms 0.995 ± 0.1
eval/Float64/evaluation 3.15 ± 0.33 ms 3.14 ± 0.32 ms 1 ± 0.15
eval/Float64/evaluation_bumper 1.19 ± 0.043 ms 1.18 ± 0.043 ms 1 ± 0.052
eval/Float64/evaluation_turbo 1.02 ± 0.06 ms 1.01 ± 0.063 ms 1 ± 0.087
eval/Float64/evaluation_turbo_bumper 1.19 ± 0.045 ms 1.18 ± 0.042 ms 1.01 ± 0.052
utils/combine_operators/break_sharing 0.0396 ± 0.00053 ms 0.0394 ± 0.00058 ms 1 ± 0.02
utils/convert/break_sharing 26.4 ± 1.8 μs 26.4 ± 1.9 μs 1 ± 0.099
utils/convert/preserve_sharing 0.0981 ± 0.0048 ms 0.0978 ± 0.0051 ms 1 ± 0.072
utils/copy/break_sharing 27.5 ± 1.4 μs 27.1 ± 1.4 μs 1.01 ± 0.072
utils/copy/preserve_sharing 0.0985 ± 0.0049 ms 0.0987 ± 0.005 ms 0.998 ± 0.071
utils/count_constant_nodes/break_sharing 12.3 ± 0.42 μs 12.5 ± 0.62 μs 0.986 ± 0.06
utils/count_constant_nodes/preserve_sharing 0.0851 ± 0.0045 ms 0.0857 ± 0.0049 ms 0.992 ± 0.077
utils/count_depth/break_sharing 13.2 ± 0.49 μs 12.6 ± 0.38 μs 1.05 ± 0.051
utils/count_nodes/break_sharing 11.6 ± 0.43 μs 11.5 ± 0.48 μs 1.01 ± 0.056
utils/count_nodes/preserve_sharing 0.0847 ± 0.0045 ms 0.0856 ± 0.0045 ms 0.989 ± 0.074
utils/get_set_constants!/break_sharing 0.0344 ± 0.0022 ms 0.0328 ± 0.0017 ms 1.05 ± 0.087
utils/get_set_constants!/preserve_sharing 0.175 ± 0.009 ms 0.177 ± 0.0087 ms 0.993 ± 0.071
utils/get_set_constants_parametric 0.0448 ± 0.0024 ms 0.0446 ± 0.0026 ms 1 ± 0.079
utils/has_constants/break_sharing 6.8 ± 0.55 μs 6.54 ± 0.46 μs 1.04 ± 0.11
utils/has_operators/break_sharing 2.54 ± 0.18 μs 2.52 ± 0.18 μs 1.01 ± 0.1
utils/hash/break_sharing 23.2 ± 0.62 μs 23.7 ± 0.66 μs 0.981 ± 0.038
utils/hash/preserve_sharing 0.0975 ± 0.0047 ms 0.098 ± 0.0046 ms 0.994 ± 0.067
utils/index_constant_nodes/break_sharing 24.8 ± 0.77 μs 24.5 ± 0.84 μs 1.01 ± 0.047
utils/index_constant_nodes/preserve_sharing 0.0979 ± 0.0047 ms 0.0974 ± 0.0043 ms 1 ± 0.066
utils/is_constant/break_sharing 7.13 ± 0.49 μs 7.14 ± 0.46 μs 0.998 ± 0.094
utils/simplify_tree/break_sharing 0.163 ± 0.0031 ms 0.159 ± 0.0031 ms 1.02 ± 0.028
utils/simplify_tree/preserve_sharing 0.217 ± 0.0089 ms 0.21 ± 0.0088 ms 1.03 ± 0.061
utils/string_tree/break_sharing 0.463 ± 0.016 ms 0.47 ± 0.019 ms 0.986 ± 0.053
utils/string_tree/preserve_sharing 0.57 ± 0.018 ms 0.582 ± 0.019 ms 0.98 ± 0.046
time_to_load 0.216 ± 0.0023 s 0.222 ± 0.0026 s 0.973 ± 0.015
Memory benchmarks
master cd69d8d... master / cd69d8d...
eval/ComplexF32/evaluation 0.987 k allocs: 2.53 MB 0.975 k allocs: 2.5 MB 1.01
eval/ComplexF64/evaluation 0.996 k allocs: 5.07 MB 0.987 k allocs: 5.03 MB 1.01
eval/Float32/derivative 4.71 k allocs: 17.7 MB 4.61 k allocs: 17.4 MB 1.02
eval/Float32/derivative_turbo 4.5 k allocs: 16.9 MB 4.68 k allocs: 17.6 MB 0.961
eval/Float32/evaluation 0.972 k allocs: 1.27 MB 0.969 k allocs: 1.26 MB 1
eval/Float32/evaluation_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float32/evaluation_turbo 0.966 k allocs: 1.26 MB 0.966 k allocs: 1.26 MB 1
eval/Float32/evaluation_turbo_bumper 0.303 k allocs: 0.393 MB 0.303 k allocs: 0.393 MB 1
eval/Float64/derivative 4.77 k allocs: 0.0349 GB 4.78 k allocs: 0.035 GB 0.996
eval/Float64/derivative_turbo 4.75 k allocs: 0.0347 GB 4.76 k allocs: 0.0348 GB 0.997
eval/Float64/evaluation 0.993 k allocs: 2.54 MB 1.01 k allocs: 2.59 MB 0.982
eval/Float64/evaluation_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
eval/Float64/evaluation_turbo 0.99 k allocs: 2.53 MB 0.981 k allocs: 2.51 MB 1.01
eval/Float64/evaluation_turbo_bumper 0.303 k allocs: 0.771 MB 0.303 k allocs: 0.771 MB 1
utils/combine_operators/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/convert/break_sharing 2 k allocs: 0.0924 MB 2 k allocs: 0.0924 MB 1
utils/convert/preserve_sharing 2.4 k allocs: 0.161 MB 2.4 k allocs: 0.161 MB 1
utils/copy/break_sharing 2 k allocs: 0.0924 MB 2 k allocs: 0.0924 MB 1
utils/copy/preserve_sharing 2.4 k allocs: 0.161 MB 2.4 k allocs: 0.161 MB 1
utils/count_constant_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_constant_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/count_depth/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/break_sharing 4 allocs: 0.953 kB 4 allocs: 0.953 kB 1
utils/count_nodes/preserve_sharing 0.404 k allocs: 0.0696 MB 0.404 k allocs: 0.0696 MB 1
utils/get_set_constants!/break_sharing 0.898 k allocs: 25.2 kB 0.898 k allocs: 25.2 kB 1
utils/get_set_constants!/preserve_sharing 1.7 k allocs: 0.138 MB 1.7 k allocs: 0.138 MB 1
utils/get_set_constants_parametric 1.42 k allocs: 0.0663 MB 1.42 k allocs: 0.0663 MB 1
utils/has_constants/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/has_operators/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/hash/break_sharing 0.104 k allocs: 2.52 kB 0.104 k allocs: 2.52 kB 1
utils/hash/preserve_sharing 0.504 k allocs: 0.0711 MB 0.504 k allocs: 0.0711 MB 1
utils/index_constant_nodes/break_sharing 1.67 k allocs: 0.0501 MB 1.67 k allocs: 0.0501 MB 1
utils/index_constant_nodes/preserve_sharing 2.07 k allocs: 0.119 MB 2.07 k allocs: 0.119 MB 1
utils/is_constant/break_sharing 4 allocs: 0.203 kB 4 allocs: 0.203 kB 1
utils/simplify_tree/break_sharing 1.33 k allocs: 0.0436 MB 1.33 k allocs: 0.0436 MB 1
utils/simplify_tree/preserve_sharing 1.58 k allocs: 0.101 MB 1.58 k allocs: 0.101 MB 1
utils/string_tree/break_sharing 11.8 k allocs: 1.04 MB 11.8 k allocs: 1.04 MB 1
utils/string_tree/preserve_sharing 12.2 k allocs: 1.11 MB 12.2 k allocs: 1.11 MB 1
time_to_load 0.159 k allocs: 11.2 kB 0.159 k allocs: 11.2 kB 1

@MilesCranmer MilesCranmer merged commit 24371c2 into master Jun 14, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant