Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marker clustering doesn't seem to work #131

Closed
gillesgerlo opened this issue Feb 13, 2018 · 6 comments
Closed

Marker clustering doesn't seem to work #131

gillesgerlo opened this issue Feb 13, 2018 · 6 comments

Comments

@gillesgerlo
Copy link

gillesgerlo commented Feb 13, 2018

Hi there,

Love the package, but can't seem to get the clustering to work. There doesn't seem to be a difference when I set cluster = T. Any help much appreciated!

google_map(data = tram_stops, key = key) %>%
  add_markers(lat = "stop_lat", lon = "stop_lon", info_window = "stop_name", cluster = TRUE)
@SymbolixAU
Copy link
Collaborator

@gillesgerlo thanks for finding this; I see the error too and will try to fix it

@SymbolixAU SymbolixAU self-assigned this Feb 13, 2018
@SymbolixAU
Copy link
Collaborator

It seems the location of the 'images' got moved when Google transferred their Maps stuff to github, but they didn't update their docs. There are many issues about this online.

For googleway I need to either store the images locally and reference them, or find a 'stable' online repo of the images.

@gillesgerlo
Copy link
Author

Thanks for looking into it :)

SymbolixAU pushed a commit that referenced this issue Feb 15, 2018
@SymbolixAU
Copy link
Collaborator

@gillesgerlo - I've just pushed a commit that I think solves the issue. It was actually nothing to do with images - I hadn't accounted for a setTimeout call I added in the last update correctly.

@SymbolixAU
Copy link
Collaborator

Could you let me know if this works for you?

You can install the dev version with

devtools::install_github("SymbolixAU/googleway")

@gillesgerlo
Copy link
Author

Works like a charm, thanks a lot!

SymbolixAU pushed a commit that referenced this issue Apr 29, 2018
@SymbolixAU SymbolixAU removed their assignment Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant