Permalink
Switch branches/tags
Nothing to show
Commits on Mar 29, 2017
Commits on Jan 25, 2017
Commits on Jan 12, 2017
Commits on Oct 24, 2016
Commits on Oct 19, 2016
  1. Fix path for phpspec tests

    svemir committed Oct 19, 2016
Commits on Feb 6, 2016
  1. skip phpspec tests in php linter

    svemir committed Feb 6, 2016
    they are already checked by the git hook, so until we can use
    the more advanced arc lint config, must skip them here
Commits on Sep 7, 2015
Commits on Sep 5, 2015
Commits on Sep 4, 2015
  1. Add temporary file support to ArcanistFileUploader

    epriestley committed Sep 4, 2015
    Summary: Ref T7148. Depends on D14055. Allows files to be marked as temporary when uploaded.
    
    Test Plan: Used `arc upload --temporary` to upload temporary files.
    
    Reviewers: chad
    
    Reviewed By: chad
    
    Maniphest Tasks: T7148
    
    Differential Revision: https://secure.phabricator.com/D14056
Commits on Sep 3, 2015
  1. Fix callsites which called libphutil_console_wrap like it were _format

    alexmv committed with epriestley Sep 3, 2015
    Summary:
    7e2df9a attempted to pht() some strings; unfortunately, it assumed
    that some things that were calls to phutil_console_wrap() were
    actually calls to phutil_console_format().  This produces errors of
    the form:
    
        [2015-07-17 21:17:28] ERROR 2: str_repeat() expects parameter 2 to be long, string given at [/usr/local/libphutil/src/console/format.php:162]
        #0 str_repeat(string, string) called at [<phutil>/src/console/format.php:162]
        #1 phutil_console_wrap(string, string, string) called at [<arcanist>/scripts/arcanist.php:620]
        #2 arcanist_load_libraries(array, boolean, string, ArcanistWorkingCopyIdentity) called at [<arcanist>/scripts/arcanist.php:154]
        %s: %s
    
    Provide an additional call to phutil_console_format() when necessary,
    or simply append the relevant characters if possible.
    
    Test Plan: Caused a library load error
    
    Reviewers: #blessed_reviewers, epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D14053
Commits on Sep 2, 2015
  1. staging repo compatibility for older git versions

    cburroughs committed with epriestley Sep 2, 2015
    Summary:
    The `--no-verify` flag was not added until git 1.8.2.  This
    flag is used to avoid running local pre-push hooks.  This is likely a
    rare configuration and is safe to omit the flag on older versions.
    Users with local pre-push hooks **and** older git version may need to
    adjust their workfow.
    
    fixes T9310
    
    Test Plan:
     * Ran `arc diff` with my real git 1.7.10.4 and succeeded with `STAGING
       PUSHED`.
     * Edited `getGitVersion` to be > 1.8.2 and pushed again.  Got
       `STAGING FAILED` because `error: unknown option`.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: joshuaspence, epriestley
    
    Maniphest Tasks: T9310
    
    Differential Revision: https://secure.phabricator.com/D14033
  2. Delete another problematic XML test file

    joshuaspence committed Sep 2, 2015
    Summary: Ref T7215. This test is occasionally failing for me locally. Remove it as per D13992.
    
    Test Plan: `arc unit`
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T7215
    
    Differential Revision: https://secure.phabricator.com/D14027
Commits on Sep 1, 2015
  1. Remove errant in arcanist.php

    yelirekim committed with epriestley Sep 1, 2015
    Summary: This causes `49` to be printed out preceding the start of my next terminal line every time there is an exception thrown.
    
    Test Plan: did not see `49` printed out when exceptions were thrown
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: epriestley
    
    Differential Revision: https://secure.phabricator.com/D14030
  2. Add a linter rule for detecting empty files

    joshuaspence committed Sep 1, 2015
    Summary: Adds two different linter rules (one general purpose and another PHP specific) to prevent empty files from being added to a repository. For some unknown reason, people seem to like to do this.
    
    Test Plan: Added test cases.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: avivey, cburroughs, Korvin
    
    Differential Revision: https://secure.phabricator.com/D13881
Commits on Aug 30, 2015
  1. Add a linter rule for newlines after PHP open tags

    joshuaspence committed Aug 30, 2015
    Summary: `<?php\n\n...` is much easier to read than `<?php\n...`. Depends on D13889 and D13890.
    
    Test Plan: Added unit tests.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: epriestley, Korvin
    
    Differential Revision: https://secure.phabricator.com/D13534
  2. Remove leftover code for "postponed" lint and unit status

    joshuaspence committed Aug 30, 2015
    Summary: Ref T9134. It looks like this functionality was removed in D13848. Depends on D13869.
    
    Test Plan: Ran `arc diff`, `arc lint` and `arc unit`.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T9134
    
    Differential Revision: https://secure.phabricator.com/D13868
Commits on Aug 29, 2015
  1. (stable) Promote 2015 Week 35

    epriestley committed Aug 29, 2015
  2. arc linters: Filter by name, make display one-line

    avivey committed with epriestley Aug 28, 2015
    Summary: allow searching/filtering linters displayed by name.
    
    Test Plan:
    `$ arc linters --verbose --search JSon --search ruby` (Lots of text about many linters)
    `$ arc linters --search JSon ruby` (error message)
    `$ arc linters python` (no results, "try --search").
    `$ arc linters ruby` (Verbose text about the "ruby" linter).
    
    Reviewers: joshuaspence, #blessed_reviewers, epriestley
    
    Reviewed By: joshuaspence, #blessed_reviewers, epriestley
    
    Subscribers: Korvin, epriestley
    
    Differential Revision: https://secure.phabricator.com/D10706
Commits on Aug 27, 2015
  1. Fix linter rule after XHPAST change

    joshuaspence committed Aug 27, 2015
    Summary: Depends on D13959.
    
    Test Plan: Ran unit tests.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D13961
Commits on Aug 26, 2015
  1. Use 'remote.origin.url' fallback for git < 1.7.5

    jarteaga committed with epriestley Aug 26, 2015
    Summary:
    'git ls-remote --get-url' is more correct, but younger and less
    supported. This commit tempers previous optimism about its availability,
    improving support for users of older git packages.
    
    Test Plan:
    * Set `git config url.xttps.insteadOf https` rewrite rule.
    * Ran `arc which` with git 1.7.5 in `$PATH`, saw rewritten configured remote.
    * Ran `arc which` with git 1.7.4 in `$PATH`, saw configured remote.
    
    Reviewers: epriestley, #blessed_reviewers
    
    Reviewed By: epriestley, #blessed_reviewers
    
    Subscribers: Korvin
    
    Differential Revision: https://secure.phabricator.com/D13998
Commits on Aug 25, 2015
  1. remove white-space diff

    svemir committed Aug 25, 2015
  2. Use 'git blame --porcelain' for git blame info

    jarteaga committed with epriestley Aug 25, 2015
    Summary:
    This guards against stability issues with the output format of 'git
    blame' (such as git config, localization (ref T5554) or future changes).
    
    For example, `git config blame.blankboundary true` breaks `arc cover`
    before this patch.
    
    Test Plan:
    * Set `git config blame.blankboundary true` on a test repo.
    * Ran `arc cover`. It failed with an exception ("Bad blame?").
    * Applied this patch.
    * `arc cover` works.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T5554
    
    Differential Revision: https://secure.phabricator.com/D13993
  3. remove unused custom linter

    svemir committed Aug 25, 2015
  4. Recover from PyLint raising messages at character "-1"

    epriestley committed Aug 25, 2015
    Summary: Fixes T9257. For some messages, PyLint can raise at "character -1", which we don't allow since we don't consider it to make sense.
    
    Test Plan:
      - Added failing unit test from T9257.
      - Applied patch.
      - Test now passes.
    
    Reviewers: joshuaspence, chad
    
    Reviewed By: joshuaspence, chad
    
    Maniphest Tasks: T9257
    
    Differential Revision: https://secure.phabricator.com/D13991
  5. Remove two problematic XML linter unit tests

    epriestley committed Aug 25, 2015
    Summary:
    Fixes T7215. See D13991. These test cases have been failing intermittently for a while.
    
    I think the XML stuff (which we don't control) changed where it raises these warnings: an old version raised them at the end of the attribute, while the new version raises them at the beginning of the attribute. Not totally 100% sure about this since installing multiple versions is fairly inconvenient, but as far as I know both versions raise the warnings, just at different character offsets.
    
    We could do various things to fix these tests (allow the warning to raise at any character, skip the tests based on versions, etc) but I think it's easier to just remove the tests. They don't seem valuable.
    
    Test Plan: Tests failed prior to change; now pass.
    
    Reviewers: chad, joshuaspence
    
    Reviewed By: joshuaspence
    
    Maniphest Tasks: T7215
    
    Differential Revision: https://secure.phabricator.com/D13992
  6. Minimize reliance on 'git branch' output format

    jarteaga committed with epriestley Aug 25, 2015
    Summary:
    Ref T5554. Both the current branch name (if on a branch), as well as the
    list of all local branches, can be retrieved without having to parse the
    output from "git branch".
    
    Unfortunately, there seems to be no git plumbing for "get list of
    branches containing this commit" yet.
    (see http://marc.info/?l=git&m=141408477614635&w=2)
    
    For that case, this commit whitelists the output from "git branch" using
    the known valid branch names from "git for-each-ref".
    
    Test Plan:
    Set up a test repo with this structure:
    ```
    |   *  Commit B1, on branch "subfeature"
    |  /
    | *    Commit A1, on branch "feature"
    |/
    *      Commit M1, on branch "master"
    |
    ```
    
    In `subfeature`, I tried:
    * `arc which --base 'git:branch-unique(master)'`
    * `arc feature`
    After that, I detached my HEAD (don't worry, I got better) and tried again.
    
    Nothing looked broken.
    
    (Tested with git 1.7.2.5 and 2.5.0.)
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: Korvin
    
    Maniphest Tasks: T5554
    
    Differential Revision: https://secure.phabricator.com/D13989
Commits on Aug 24, 2015
  1. fix missing class vars

    svemir committed Aug 24, 2015
  2. Avoid parsing git "remote show" using "ls-remote"

    jarteaga committed with epriestley Aug 24, 2015
    Summary:
    Ref T5554. This makes git remote URL detection locale-agnostic.
    
    The previously suggested `git config remote.origin.url` command does
    almost the same, but does not support the URL rewriting features in
    git-config (`url.<base>.insteadOf`).
    
    This one does, although it has the unintuitive behavior of just printing
    the passed remote name when the remote does not exist, or even when
    called outside a git repo.
    
    Test Plan:
    * Switched to non-english locale in which git has a translation.
    * Ran `arc which` on the Arcanist repo. It could not determine the remote URI.
    * Applied patch, `arc which` found the URI.
    
    Reviewers: #blessed_reviewers, epriestley
    
    Reviewed By: #blessed_reviewers, epriestley
    
    Subscribers: johnny-bit, Korvin
    
    Maniphest Tasks: T5554
    
    Differential Revision: https://secure.phabricator.com/D13983
Commits on Aug 23, 2015
Commits on Aug 22, 2015
  1. Merge remote-tracking branch 'upstream/master'

    svemir committed Aug 22, 2015
    Conflicts:
    	src/__phutil_library_map__.php
    	src/lint/linter/ArcanistLinter.php
    	src/workflow/ArcanistBaseWorkflow.php
    	src/workflow/ArcanistSvnHookPreCommitWorkflow.php