Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Statie] Add init command #1285

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@TomasVotruba
Copy link
Member

commented Dec 30, 2018

Closes #1282

Usage

asciicast

vendor/bin/statie init

Do you preffer latte?

vendor/bin/statie init --templating latte
# same as
vendor/bin/statie init -t latte

Todo

  • add note to README.md

@TomasVotruba TomasVotruba force-pushed the statie-init branch from 8ac05dc to 966aa6f Dec 30, 2018

@TomasVotruba

This comment has been minimized.

Copy link
Member Author

commented Dec 30, 2018

@crazko Could I ask you for feedback on this? I'm blind-author :)

@TomasVotruba

This comment has been minimized.

Copy link
Member Author

commented Dec 30, 2018

@JanMikes This command should solve Statie setup in seconds :). Could I ask you for feedback on this?

@crazko

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2019

Have you considered to give an option to choose between twig and latte? I think it'd be great.

@TomasVotruba

This comment has been minimized.

Copy link
Member Author

commented Jan 1, 2019

Have you considered to give an option to choose between twig and latte? I think it'd be great.

Good idea 👍 , it should be pretty simple here since it's bunch of copy-pasted files.

Thank you, that's exactly feedback I needed.

@TomasVotruba TomasVotruba force-pushed the statie-init branch 3 times, most recently from 8851e2a to 4ad7e25 Jan 2, 2019

@TomasVotruba

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

Small update :) check the Usage in the top.

Is there anything else you'd change?

@crazko
Copy link
Contributor

left a comment

I think it looks great. I've just added some small notes.

Show resolved Hide resolved packages/Statie/templates/statie-website-twig/source/assets/css/style.css Outdated
Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved packages/Statie/templates/statie-website/package.json Outdated

@TomasVotruba TomasVotruba force-pushed the statie-init branch from 43fbb42 to 1247cad Jan 2, 2019

@TomasVotruba TomasVotruba force-pushed the statie-init branch from 1247cad to a521dea Jan 2, 2019

@TomasVotruba

This comment has been minimized.

Copy link
Member Author

commented Jan 2, 2019

Thank you, your feedback made this feature 5 times better :)

@TomasVotruba TomasVotruba merged commit f9717e0 into master Jan 2, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@TomasVotruba TomasVotruba deleted the statie-init branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.