From 9ed2d3116d9a99a324ff6437dd6f4abef56413fa Mon Sep 17 00:00:00 2001 From: Kamil Matysiewicz Date: Mon, 19 Mar 2018 18:48:32 +0100 Subject: [PATCH 1/2] Run npm install on registry socket and fix registry dependencies. --- packages/cli/src/commands/socket-add.js | 14 +++++++++----- packages/cli/src/utils/sockets/sockets.js | 18 ++++++++++++------ 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/packages/cli/src/commands/socket-add.js b/packages/cli/src/commands/socket-add.js index 942e6ce3..dd9e32fe 100644 --- a/packages/cli/src/commands/socket-add.js +++ b/packages/cli/src/commands/socket-add.js @@ -26,12 +26,12 @@ export default class SocketAdd { if (cmd.socket) { // Socket dependency this.socket = await this.Socket.get(cmd.socket) - return this.socket.addDependency(socketFromRegistry) + await this.socket.addDependency(socketFromRegistry) + } else { + // Project dependency + await this.Socket.add(socketFromRegistry) } - // Project dependency - await this.Socket.add(socketFromRegistry) - const status = format.grey('socket added:') const name = format.cyan(this.socketFromRegistry.name) const version = format.dim(`(${this.socketFromRegistry.version})`) @@ -61,7 +61,11 @@ export default class SocketAdd { } } else { echo() - echo(`${format.red(err)}\n`) + if(err.message) { + echo(`${format.red(err.message)}\n`) + } else { + echo(`${format.red(err)}\n`) + } echo() } } diff --git a/packages/cli/src/utils/sockets/sockets.js b/packages/cli/src/utils/sockets/sockets.js index 7a2a8a09..79728ae0 100644 --- a/packages/cli/src/utils/sockets/sockets.js +++ b/packages/cli/src/utils/sockets/sockets.js @@ -329,11 +329,10 @@ class Socket { debug(`Getting Socket: ${socketName}`) const socket = Socket.getLocal(socketName) const loadedSocket = await socket.loadRemote() - await loadedSocket.getDepsRegistrySockets() - if (!socket.existLocally) { await socket.loadFromRegistry() } + await loadedSocket.getDepsRegistrySockets() return socket } @@ -564,7 +563,7 @@ class Socket { getSocketNodeModulesChecksum () { debug('getSocketNodeModulesChecksum') - return hashdirectory.sync(path.join(this.socketPath, '.dist', 'node_modules')) + return hashdirectory.sync(path.join(this.getSocketPath(), '.dist', 'node_modules')) } getSocketConfigFile () { @@ -1018,12 +1017,19 @@ class Socket { await Registry.getSocket(this) const fileName = path.join(session.getBuildPath(), `${this.name}.zip`) - await new Promise((resolve, reject) => { + await new Promise(async (resolve, reject) => { fs.createReadStream(fileName) .pipe(unzip.Extract({ path: this.getSocketPath() })) - .on('close', () => { + .on('close', async () => { debug('Unzip finished') - resolve() + + // Build registry socket. + try { + await this.build() + } catch(e) { + return reject(e) + } + return resolve() }) }) } From 681b2d85c5d8bb2061c59a0ef32d4099b8f80223 Mon Sep 17 00:00:00 2001 From: Kamil Matysiewicz Date: Tue, 20 Mar 2018 09:31:36 +0100 Subject: [PATCH 2/2] Remove unnecessary async. --- packages/cli/src/utils/sockets/sockets.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/utils/sockets/sockets.js b/packages/cli/src/utils/sockets/sockets.js index 79728ae0..d6f91bb9 100644 --- a/packages/cli/src/utils/sockets/sockets.js +++ b/packages/cli/src/utils/sockets/sockets.js @@ -1017,7 +1017,7 @@ class Socket { await Registry.getSocket(this) const fileName = path.join(session.getBuildPath(), `${this.name}.zip`) - await new Promise(async (resolve, reject) => { + await new Promise((resolve, reject) => { fs.createReadStream(fileName) .pipe(unzip.Extract({ path: this.getSocketPath() })) .on('close', async () => {