Skip to content
Permalink
Browse files

macOS: fix random password loaded in the GUI

macOS puts a -psn_0_xxxxxx argument when running an app via GUI.
This argument was interpreted as a password (-p) and overloaded the
value stored in the settings. Catching the -psn argument explicitely
should prevent this.

See https://stackoverflow.com/questions/10242115/os-x-strange-psn-command-line-parameter-when-launched-from-finder
for further information about this legacy argument.
  • Loading branch information...
albertosottile committed May 10, 2019
1 parent a2294d0 commit b3545a35bb5f5398584afb1e4f4df6a6004c3460
Showing with 1 addition and 0 deletions.
  1. +1 −0 syncplay/ui/ConfigurationGetter.py
@@ -490,6 +490,7 @@ def getConfiguration(self):
self._argparser.add_argument('-r', '--room', metavar='room', type=str, nargs='?', help=getMessage("room-argument"))
self._argparser.add_argument('-p', '--password', metavar='password', type=str, nargs='?', help=getMessage("password-argument"))
self._argparser.add_argument('--player-path', metavar='path', type=str, help=getMessage("player-path-argument"))
self._argparser.add_argument('-psn', metavar='blackhole', type=str, help=argparse.SUPPRESS)
self._argparser.add_argument('--language', metavar='language', type=str, help=getMessage("language-argument"))
self._argparser.add_argument('file', metavar='file', type=str, nargs='?', help=getMessage("file-argument"))
self._argparser.add_argument('--clear-gui-data', action='store_true', help=getMessage("clear-gui-data-argument"))

0 comments on commit b3545a3

Please sign in to comment.
You can’t perform that action at this time.