New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to manually reconnect #122

Closed
alok0 opened this Issue Dec 10, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@alok0

alok0 commented Dec 10, 2016

the automatic reconnect aborts after a certain amount of time, this seems like a flaw to me.

but on top of that there no way to manually reconnect.

@Et0h Et0h assigned Et0h and Uriziel and unassigned Et0h Dec 10, 2016

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 10, 2016

Contributor

Uriziel did the original reconnect code so I'm not very familiar with it, and Uriziel lasted worked on it in 2013. As such, it might be difficult to say how easy it would be to change things without risking breaking things. How frequently is being disconnected for long periods an issue for you?

Contributor

Et0h commented Dec 10, 2016

Uriziel did the original reconnect code so I'm not very familiar with it, and Uriziel lasted worked on it in 2013. As such, it might be difficult to say how easy it would be to change things without risking breaking things. How frequently is being disconnected for long periods an issue for you?

@Et0h Et0h added the enhancement label Dec 10, 2016

@alok0

This comment has been minimized.

Show comment
Hide comment
@alok0

alok0 Dec 10, 2016

This is not normally an issue, but the easy fix would be to never give up reconnecting.

alok0 commented Dec 10, 2016

This is not normally an issue, but the easy fix would be to never give up reconnecting.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 10, 2016

Contributor

Yes, one way to do that would be to remove the RECONNECT_RETRIES constant and the check on self._timesTried in clientConnectionLost and then limit the maximum retry interval increase on the callLater

Contributor

Et0h commented Dec 10, 2016

Yes, one way to do that would be to remove the RECONNECT_RETRIES constant and the check on self._timesTried in clientConnectionLost and then limit the maximum retry interval increase on the callLater

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 11, 2016

Contributor

Alternatively, number of RECONNECT_RETRIES could just be set very high alongside the gap between attempts being limited. Does anyone have any good reason to prevent too may reconnection attempts?

Contributor

Et0h commented Dec 11, 2016

Alternatively, number of RECONNECT_RETRIES could just be set very high alongside the gap between attempts being limited. Does anyone have any good reason to prevent too may reconnection attempts?

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 24, 2016

Contributor

Okay, that update should do it...

Contributor

Et0h commented Dec 24, 2016

Okay, that update should do it...

@Et0h Et0h closed this Dec 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment