-
Notifications
You must be signed in to change notification settings - Fork 223
no way to manually reconnect #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Uriziel did the original reconnect code so I'm not very familiar with it, and Uriziel lasted worked on it in 2013. As such, it might be difficult to say how easy it would be to change things without risking breaking things. How frequently is being disconnected for long periods an issue for you? |
This is not normally an issue, but the easy fix would be to never give up reconnecting. |
Yes, one way to do that would be to remove the RECONNECT_RETRIES constant and the check on self._timesTried in clientConnectionLost and then limit the maximum retry interval increase on the callLater |
Alternatively, number of RECONNECT_RETRIES could just be set very high alongside the gap between attempts being limited. Does anyone have any good reason to prevent too may reconnection attempts? |
Okay, that update should do it... |
This feature would be nice because sometimes I am mid way through a video, and I close my laptop overnight, and when I want to continue again I have to restart SyncPlay |
This is something which should be addressed on private servers with room permeance/persistence enabled when #434 gets integrated. |
the automatic reconnect aborts after a certain amount of time, this seems like a flaw to me.
but on top of that there no way to manually reconnect.
The text was updated successfully, but these errors were encountered: