Skip to content

Double "user joined" message when changing room with isolate rooms mode #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Et0h opened this issue Dec 10, 2016 · 1 comment
Closed
Assignees

Comments

@Et0h
Copy link
Contributor

Et0h commented Dec 10, 2016

On changing room the "user joined" message is caused to display twice. It only occurs in isolate rooms mode, so the problem is probably with PublicRoomManager. Reported by Corwin.

[19:31:03] <Bob> has joined the room: 'Foo'
[19:31:07] <Bob> has joined the room: 'Bar'
[19:31:08] <Bob> has joined the room: 'Bar'
[19:32:17] <Alice> has joined the room: 'bar'
[19:32:17] <Alice> has joined the room: 'bar'
@Et0h
Copy link
Contributor Author

Et0h commented Dec 16, 2016

To reproduce join a public server with no file open, then join a second room still with no file open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants