Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay seeks to the position in the previous file on playlist change #138

Closed
Jokler opened this issue Aug 4, 2017 · 5 comments
Closed

Syncplay seeks to the position in the previous file on playlist change #138

Jokler opened this issue Aug 4, 2017 · 5 comments
Assignees
Labels

Comments

@Jokler
Copy link

@Jokler Jokler commented Aug 4, 2017

We usually use the playlist to add videos which we want to add next.
If you manually change from one video to the next(e.g. you skip the outro of a video) Syncplay skips into the next video - possibly spoiling its contents.

Since we almost never need this behaviour and it often gets in the way it would be nice to hear from more people if they need it or would rather want it changed.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Aug 12, 2017

The current expected behaviour is that Syncplay only rewinds when it is autoplaying the next file or if you shift+drag the file in to Syncplay. I'm happy with making it also rewind when you change playlist item. Anyone have any strong views in favour or against?

@Et0h
Copy link
Contributor

@Et0h Et0h commented Aug 12, 2017

If the behaviour is changed then there could be a "change without rewind" menu item too, but not sure if that'd add unnecessary complexity.

@captaincolonelfox
Copy link

@captaincolonelfox captaincolonelfox commented Aug 23, 2017

Have the same problem with next episode in list. It will be very useful thing for me. Even checkbox in menu will be ok :)

@Et0h Et0h self-assigned this Sep 10, 2017
@Et0h Et0h added the enhancement label Sep 10, 2017
@Et0h
Copy link
Contributor

@Et0h Et0h commented Oct 12, 2017

It seems like the consensus view is to make this change, so I'll do that next time I have some free time (unless someone else gets to it first).

Et0h added a commit that referenced this issue Oct 14, 2017
@Et0h
Copy link
Contributor

@Et0h Et0h commented Oct 14, 2017

The changes I've made should do the trick. Let me know if it doesn't work.

@Et0h Et0h closed this Oct 14, 2017
albertosottile added a commit to albertosottile/syncplay that referenced this issue Oct 15, 2017
albertosottile added a commit to albertosottile/syncplay that referenced this issue Oct 15, 2017
albertosottile added a commit to albertosottile/syncplay that referenced this issue Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.