Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OS X][UI Request] Add a /Volumes/ shortcut. #149

Closed
Duamer opened this issue Sep 19, 2017 · 8 comments
Closed

[OS X][UI Request] Add a /Volumes/ shortcut. #149

Duamer opened this issue Sep 19, 2017 · 8 comments

Comments

@Duamer
Copy link

@Duamer Duamer commented Sep 19, 2017

Small request. Add a way to easily get to the /Volumes/ directory in the "Set media directories" interface. My workaround was to manually type the path, but many users wouldn't think to do that.

I would suggest adding a shortcut in the "Find Directory" window and an exception so that same window can see the directory in the root of the drive.

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Sep 19, 2017

From a strictly technical point of view, this is possible, although it requires a fairly large amount of code rewriting. The self-initializing function getExistingDirectory needs to be replaced with a custom QFileDialog, encapsulated in a new method, and manually designed to behave in the same way, so to select only directories. Then, the /Volumes/ path could be added in it by using setSidebarUrls.

But, we should not forget that this issue was actually created by the use of non-native QFileDialogs instead of native dialogs, and that we had to introduce it as a workaround for some obscure qt4 bug on macOS. In macOS native file dialogs, this issue does not exist because the Finder shows all the mounted volumes in its sidebar.

Fixing this issue will require writing a substantial amount of macOS specific code that

  • could stop working in the next major macOS release in a few days
  • violates Apple's Human Interface Guidelines as it exposes the /Volumes/ folder to the GUI
  • will become obsolete the day Syncplay migrates to qt5.

So, at this moment, I think this issue should not be fixed. I am of course open to suggestions.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Dec 9, 2017

@alby128 @Duamer Now that we have Qt.py Pyside2 support is this fully resolved?

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Dec 9, 2017

It will be resolved if and only if he uses PySide2 as binding.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Dec 9, 2017

@alby128 Okay, so I guess that before closing this issue we need a short sentence explaining the problem and how it can be resolved for the Troubleshooting guide at http://syncplay.pl/guide/trouble/

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Dec 9, 2017

@Et0h I tend to agree, although we are not providing anymore a guide to manually install Syncplay on macOS, so this possibility will be available only for experienced users. Maybe we should just leave this issue open until we switch to PySide2 in packaged .exe and .dmg .

@Et0h
Copy link
Contributor

@Et0h Et0h commented Dec 9, 2017

@alby128 Happy to keep this open until we have it packaged in .dmg. Not sure why there would be a need for it to be packaged in the Windows .exe, though.

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Dec 9, 2017

@Et0h I just thought you wanted to keep all the platforms on the same binding, but that is not really necessary, you are right.

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Jun 17, 2018

Fixed in 1.5.4 RC1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants