New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MPC-BE #158

Closed
marwanpro opened this Issue Nov 11, 2017 · 9 comments

Comments

Projects
None yet
3 participants
@marwanpro

marwanpro commented Nov 11, 2017

Hello,

I use MPC-BE (Like MPC-HE, but with black UI and some improvements..)

It seems to not be usable. Can you add support, thanks

Exe name: mpc-be64.exe

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Nov 11, 2017

Contributor

We have looked into this before and it turned out that because MPC-BE did not support the latest version of the MPC-HC API there was nothing we could do from within Syncplay to support it. As such, you should be asking MPC-BE to support Syncplay rather than asking Syncplay to support MPC-BE. If MPC-BE ever supports the current MPC-HC API (i.e. the features which Uriziel added to MPC-HC back in 2012) then we'd love for someone to let us know because then we could just tweak our MPC-HC code to support MPC-BE.

Contributor

Et0h commented Nov 11, 2017

We have looked into this before and it turned out that because MPC-BE did not support the latest version of the MPC-HC API there was nothing we could do from within Syncplay to support it. As such, you should be asking MPC-BE to support Syncplay rather than asking Syncplay to support MPC-BE. If MPC-BE ever supports the current MPC-HC API (i.e. the features which Uriziel added to MPC-HC back in 2012) then we'd love for someone to let us know because then we could just tweak our MPC-HC code to support MPC-BE.

@marwanpro

This comment has been minimized.

Show comment
Hide comment
@marwanpro

marwanpro Nov 12, 2017

Thanks for your reply.

Here the API of MPC-BE (from the official SVN): http://svn.code.sf.net/p/mpcbe/code/tags/release_1.5.1/src/apps/mplayerc/mpcapi.h

marwanpro commented Nov 12, 2017

Thanks for your reply.

Here the API of MPC-BE (from the official SVN): http://svn.code.sf.net/p/mpcbe/code/tags/release_1.5.1/src/apps/mplayerc/mpcapi.h

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Nov 12, 2017

Contributor

Missing from MPC-BE 1.5.1 API:

  • CMD_VERSION = 0x5000000A,
  • CMD_DISCONNECT = 0x5000000B,
  • CMD_PLAY = 0xA0000004,
  • CMD_PAUSE = 0xA0000005,
  • CMD_GETVERSION = 0xA0003006
  • CMD_SETSPEED = 0xA0004008,

It also seems like they haven't fixed the bug which prevents 32-bit applications from working with the 64-bit version, which is to add " : unsigned int" after "typedef enum MPCAPI_COMMAND" (MPC-HC ticket #2470)

For a full list of differences see: https://www.diffnow.com/?report=la7xp

Contributor

Et0h commented Nov 12, 2017

Missing from MPC-BE 1.5.1 API:

  • CMD_VERSION = 0x5000000A,
  • CMD_DISCONNECT = 0x5000000B,
  • CMD_PLAY = 0xA0000004,
  • CMD_PAUSE = 0xA0000005,
  • CMD_GETVERSION = 0xA0003006
  • CMD_SETSPEED = 0xA0004008,

It also seems like they haven't fixed the bug which prevents 32-bit applications from working with the 64-bit version, which is to add " : unsigned int" after "typedef enum MPCAPI_COMMAND" (MPC-HC ticket #2470)

For a full list of differences see: https://www.diffnow.com/?report=la7xp

@v0lt

This comment has been minimized.

Show comment
Hide comment
@v0lt

v0lt Nov 14, 2017

Try MPC-BE 1.5.2.3123 or later.

v0lt commented Nov 14, 2017

Try MPC-BE 1.5.2.3123 or later.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 8, 2017

Contributor

Thanks @v0lt for https://sourceforge.net/p/mpcbe/code/3116/ and https://sourceforge.net/p/mpcbe/code/3119/

Seems to work on a cursory test with MPC-BE 1.5.2.3148 x64, but haven't done a thorough test. If you are using MPC-BE 1.5.2.3123 or above then please copy mpc-be64.exe and rename it mpc-hc64.exe (or mpc-be.exe and rename it mpc-hc.exe), set that as the path to player executable in Syncplay 1.5.0, and tell me how well it works. If we can confirm it works without issue then we can add recognition of the MPC-BE executable filenames to Syncplay. If there are issues we can see if they can be resolved Syncplay-side or if they need further changes to MPC-BE.

@joeoe asked about MPC-BE support back in 2015 (#68) so they might be able to test it too.

Contributor

Et0h commented Dec 8, 2017

Thanks @v0lt for https://sourceforge.net/p/mpcbe/code/3116/ and https://sourceforge.net/p/mpcbe/code/3119/

Seems to work on a cursory test with MPC-BE 1.5.2.3148 x64, but haven't done a thorough test. If you are using MPC-BE 1.5.2.3123 or above then please copy mpc-be64.exe and rename it mpc-hc64.exe (or mpc-be.exe and rename it mpc-hc.exe), set that as the path to player executable in Syncplay 1.5.0, and tell me how well it works. If we can confirm it works without issue then we can add recognition of the MPC-BE executable filenames to Syncplay. If there are issues we can see if they can be resolved Syncplay-side or if they need further changes to MPC-BE.

@joeoe asked about MPC-BE support back in 2015 (#68) so they might be able to test it too.

@Et0h Et0h reopened this Dec 8, 2017

Et0h added a commit that referenced this issue Dec 9, 2017

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 9, 2017

Contributor

Syncplay with MPC-BE support test build available from http://syncplay.pl/syncplay_v1.5.0_mpcbe.zip - please test it and let me know how it works.

Contributor

Et0h commented Dec 9, 2017

Syncplay with MPC-BE support test build available from http://syncplay.pl/syncplay_v1.5.0_mpcbe.zip - please test it and let me know how it works.

@Et0h Et0h removed the invalid label Dec 9, 2017

@marwanpro

This comment has been minimized.

Show comment
Hide comment
@marwanpro

marwanpro Dec 9, 2017

Hello,

It seems to work fine, no apparent lags, every functions seems to work fine.

Thanks bro

marwanpro commented Dec 9, 2017

Hello,

It seems to work fine, no apparent lags, every functions seems to work fine.

Thanks bro

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 9, 2017

Contributor

@marwanpro Thanks for testing it. I've not had any problems with it either so it seems good to include in the next release of Syncplay.

Contributor

Et0h commented Dec 9, 2017

@marwanpro Thanks for testing it. I've not had any problems with it either so it seems good to include in the next release of Syncplay.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 27, 2017

Contributor

MPC-BE support is now in Syncplay 1.5.1: http://syncplay.pl/syncplay-1-5-1/

Contributor

Et0h commented Dec 27, 2017

MPC-BE support is now in Syncplay 1.5.1: http://syncplay.pl/syncplay-1-5-1/

@Et0h Et0h closed this Dec 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment