Skip to content

/ syncplay

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional characters #174

Closed
Corginyan opened this issue Feb 1, 2018 · 3 comments
Closed

Additional characters #174

Corginyan opened this issue Feb 1, 2018 · 3 comments

Comments

@Corginyan
Copy link

@Corginyan Corginyan commented Feb 1, 2018

Can't type "А" or "а" characters in MPV chat (first letter of cyrillic alphabet). Maybe problem is here:

syncplay/resources/syncplayintf.lua

Line 63 in 406e9a4

non_us_chars = {

Et0h added a commit that referenced this issue Feb 4, 2018
@Et0h
Add first letter of Cyrillic alphabet to Syncplay mpv script (#174 ra…
Loading status checks…
0e91265 
…ised by Corginyan)
@Et0h
Copy link
Contributor

@Et0h Et0h commented Feb 4, 2018

Thanks for reporting this omission. Does replacing your /resources/syncplayintf.lua file with https://raw.githubusercontent.com/Syncplay/syncplay/master/resources/syncplayintf.lua succeed in allowing the input of the first letter of the Cyrillic alphabet through mpv? Are there any other characters that need adding?
@Corginyan
Copy link
Author

@Corginyan Corginyan commented Feb 5, 2018

succeed in allowing the input of the first letter of the Cyrillic alphabet through mpv?

Yes.

Are there any other characters that need adding?

Now i can input every cyrillic character.
Nico769 pushed a commit to Nico769/syncplay that referenced this issue Feb 6, 2018
Nicola Landolfi
Merge pull request #1 from Syncplay/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
cb9a46a 
Add first letter of Cyrillic alphabet to Syncplay mpv script (Syncplay#174 ra…
Nico769 pushed a commit to Nico769/syncplay that referenced this issue Feb 6, 2018
Nicola Landolfi
Revert "Add first letter of Cyrillic alphabet to Syncplay mpv script (S…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
9fe1345 
…yncplay#174 ra…"
albertosottile added a commit to albertosottile/syncplay that referenced this issue Feb 9, 2018
@Et0h @albertosottile
Add first letter of Cyrillic alphabet to Syncplay mpv script (Syncpla…
3f842a2 
…y#174 raised by Corginyan)
albertosottile added a commit to albertosottile/syncplay that referenced this issue Feb 9, 2018
@Et0h @albertosottile
Add first letter of Cyrillic alphabet to Syncplay mpv script (Syncpla…
139f3f5 
…y#174 raised by Corginyan)
albertosottile added a commit to albertosottile/syncplay that referenced this issue Feb 12, 2018
@Et0h @albertosottile
Add first letter of Cyrillic alphabet to Syncplay mpv script (Syncpla…
83a5dde 
…y#174 raised by Corginyan)
@Et0h
Copy link
Contributor

@Et0h Et0h commented Mar 3, 2018

This issue should now be resolved by the Syncplay 1.5.2 Official Release so I'll close the issue for now. If the issue persists then please let me know.
@Et0h Et0h closed this Mar 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Et0h @Corginyan