Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay server no longer works with --password option #200

Closed
alxpettit opened this issue Aug 31, 2018 · 1 comment
Closed

Syncplay server no longer works with --password option #200

alxpettit opened this issue Aug 31, 2018 · 1 comment

Comments

@alxpettit
Copy link
Contributor

@alxpettit alxpettit commented Aug 31, 2018

Syncplay server exits with TypeError when I try to start it with --password option.

[syncplay@caesium ~]$ /usr/bin/syncplay-server --port [REDACTED] --password [REDACTED]                          
Welcome to Syncplay server, ver. 1.5.6
Traceback (most recent call last):
  File "/usr/bin/syncplay-server", line 36, in <module>
    args.stats_db_file))
  File "/usr/lib/syncplay/syncplay/server.py", line 28, in __init__
    password = hashlib.md5(password).hexdigest()
TypeError: Unicode-objects must be encoded before hashing

I fixed the code by adding password = password.encode('utf-8') before line 28 in server.py. Some similar modification should be made to fix this regression. 😉

Et0h added a commit that referenced this issue Sep 2, 2018
@Et0h
Copy link
Contributor

@Et0h Et0h commented Sep 2, 2018

Your suggested fix has now been implemented. Thank you for flying with Syncplay :)

@Et0h Et0h closed this Sep 2, 2018
albertosottile added a commit to albertosottile/syncplay that referenced this issue Sep 5, 2018
albertosottile added a commit to albertosottile/syncplay that referenced this issue Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants