Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature request: Recognize type of VLC install on the system (package manager vs. Snap) #222
With VLC having bought-in wholesale to Canonical's Snap packaging ecosystem (I'm decidedly not a fan for a host of reason including [but not limited to]: increased storage overhead, atrocious integration with AppArmor, old snapshots lingering after updates with no garbage collection, the eighth circle of app theming hell) it might be time to build an awareness into the install process for both types so that it can correctly locate the Lua script where it will be seen and used. I've been doing this manually with each SyncPlay install/upgrade and it's no biggie, but the project can't gain more widespread adoption without supporting less geeky users.
The two installation folders being:
I would think a simple if statement for each would suffice. My first thought for those is to use
For testing if the Snap package is present the solution seems less elegant, requiring piping the output of
Anyhow, thanks for making a nifty open-source tool and maintaining it for all these years and I hope my thoughts here don't come across as presumptuous or too dumb. I don't even recall how I found Syncplay to begin with (TWiT show, maybe?) but it's a handy thing to have in my bag of tricks when the need arises.
The GIT HEAD of Syncplay moves from installing the syncplay.lua script when you install Syncplay to copying it into the user folder if it does not exist when you actually try to run VLC through Syncplay. If the current GIT HEAD does not work then please make a pull request which detects /snap/ in the VLC directory and copies to the appropriate User INTF directory.
How to do this: Change the portion of https://github.com/Syncplay/syncplay/blob/master/syncplay/players/vlc.py for the line which reads
You can also add the relevant VLC path to