New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube-dl not working on mpv client inside syncplay #228
Comments
Thanks for reporting this. We need further information to reproduce the issue:
|
Syncplay: 1.6.2 Running on OSX Mojave 10.14.3 Any URL fail, for example https://www.youtube.com/watch?v=VrS6akzR3sk. |
Reproduced EDIT My error message is quite different, though:
|
Sometimes I also get that error, which made me think Thanks for checking, though, and awesome work with Syncplay 🏆 |
I was wrong, the bug is reproducible at least on 10.13 and 10.14 (but probably also on older systems) and from Syncplay 1.5.0. So, thank you for reporting this! We identified |
youtube-dl relies on system python to run on macOS, but system python cannot be executed in a subprocess created from the frozen python3 executable. This makes youtube-dl unusable from frozen versions of Syncplay on macOS. So, the environment of the mpv subprocess is modified with system PYTHONPATH, allowing the execution of /usr/bin/python (and hence, of youtube-dl) from within the subprocess also in frozen executables. Fixes: Syncplay#228
youtube-dl relies on system python to run on macOS, but system python cannot be executed in a subprocess created from the frozen python3 executable. This makes youtube-dl unusable from frozen versions of Syncplay on macOS. So, the environment of the mpv subprocess is modified with system PYTHONPATH, allowing the execution of /usr/bin/python (and hence, of youtube-dl) from within the subprocess in frozen executables. Fixes: Syncplay#228
youtube-dl relies on system python to run on macOS, but system python cannot be executed in a subprocess created from the frozen python3 executable. This makes youtube-dl unusable from frozen versions of Syncplay on macOS. So, the environment of the mpv subprocess is modified with system PYTHONPATH, allowing the execution of /usr/bin/python (and hence, of youtube-dl) from within the subprocess in frozen executables. Fixes: Syncplay#228
@brenolf Could you please test the fix on your system? If you are running Syncplay from the packed dmg, you can download an updated test version from my Bintray: |
yes, it works! thanks @albertosottile! |
Thank you for testing this. I am going to close this issue now. Remember to download the next official release of Syncplay with the included fix as soon as it is ready. |
thanks for the fast fix! 🚀 |
For other people that might face this problem: running on
Caused error on some videos. Solved by upgrading |
Whenever I try to add an URL to syncplay playlist to run, MPV will throw
This doesn't happen if I call mpv directly from the terminal, even if I pass
--player-operation-mode=pseudo-gui
to it, it will normally play the video.youtube-dl
is on/usr/local/bin/youtube-dl
and/usr/local/bin
is on my PATH.The text was updated successfully, but these errors were encountered: