Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay (in CLI mode) hangs when entering common keypresses during termination sequence #238

Closed
crabdancing opened this issue Jun 15, 2019 · 4 comments

Comments

@crabdancing
Copy link
Contributor

Status

System: Linux caesium 5.0.19.a-1-hardened #1 SMP PREEMPT Tue May 28 23:55:46 CEST 2019 x86_64 GNU/Linux
Syncplay Version: 1.6.3.r10.g3a4cf41-1

Should have been pulled fresh from the git repo as of today (2019-06-15), if my AUR system is working as intended.

Steps to reproduce:

  1. Close media player window.
  2. When you get the Press enter to exit, do what I did and press Ctrl+D instead on muscle memory.
  3. Watch in awe as it becomes completely non-responsive to all input and has to be terminated with a SIGKILL.

No error messages, even when running with --debug flag.

@albertosottile
Copy link
Member

@alxpettit Just two quick questions for you: was your player mpv? Did you close the player to trigger the Press enter to exit message? Thanks.

@crabdancing
Copy link
Contributor Author

crabdancing commented Jun 18, 2019

Yes, MPV. And yeah, I closed the media player window. Just pressed Q.

@albertosottile
Copy link
Member

Thanks for reporting this. We are going to eliminate that prompt request entirely and let Syncplay close automatically in those cases, since that prompt was inserted there for historical reasons that should no longer be relevant.

@crabdancing
Copy link
Contributor Author

Yay, thanks ^_^

albertosottile added a commit to albertosottile/syncplay that referenced this issue Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants