Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"This client does not support TLS" on Windows 1.6.4 #241

Closed
Tremolo4 opened this issue Jun 21, 2019 · 5 comments
Closed

"This client does not support TLS" on Windows 1.6.4 #241

Tremolo4 opened this issue Jun 21, 2019 · 5 comments

Comments

@Tremolo4
Copy link
Contributor

@Tremolo4 Tremolo4 commented Jun 21, 2019

I just updated to v1.6.4 using Syncplay-1.6.4-Setup.exe but my Windows client still shows

This client does not support TLS

when connecting to my TLS-enabled server.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Jun 22, 2019

Does it work fine with the portable version?

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Jun 22, 2019

Hi, thanks for reporting this. Did you try to use the same client with one of our public servers?

If you could run the client in debug mode, you could get more useful error messages in the log file. Please, run it from the cmd prompt with --debug as argument, then look in the %APPDATA%\.syncplay.log file and paste here its content.

Also, if you could try to connect to your server from another platform (Linux or macOS) and confirm that TLS works fine in such a case, that would be great.

@Tremolo4
Copy link
Contributor Author

@Tremolo4 Tremolo4 commented Jun 22, 2019

Happened as well with the public servers, then I went to run it with --debug, so opened a console in the Syncplay folder and ran Syncplay.exe --debug and encryption worked. Also works without --debug.

🤔

So I went to check the syncplay shortcut in my start menu and it turns out the directory to execute in is set to "C:\Program Files (x86)\Syncplay\styles". Running it from the styles folder in the console triggers the "does not support TLS" message as well. Seems like that's the problem! I'm quite certain I didn't touch the shortcut, so it must have been created like this by the installer.

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Jun 22, 2019

We added an instruction in our NSIS script that should explicitly set the "start in" path in links generated by NSIS. @Tremolo4 can you test the updated installer generated by our CI? Thanks.

@Tremolo4
Copy link
Contributor Author

@Tremolo4 Tremolo4 commented Jun 23, 2019

I ran your linked installer over my current installation with the broken shortcut and it got fixed. Also tested uninstalling and re-installing with the new installer, also worked.

Nice, thanks!

albertosottile added a commit to albertosottile/syncplay that referenced this issue Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants