Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in client.py:FileSwitchManager.setClient() #282

Closed
siiky opened this issue Mar 26, 2020 · 1 comment
Closed

Typo in client.py:FileSwitchManager.setClient() #282

siiky opened this issue Mar 26, 2020 · 1 comment
Labels
bug / problem

Comments

@siiky
Copy link

@siiky siiky commented Mar 26, 2020

Shouldn't it be _client here? I see that setClient() isn't used right now, but it could be the origin of a bug in the future.

syncplay/syncplay/client.py

Line 1900 in bf5c8dd

self.client = newClient

@Et0h
Copy link
Contributor

@Et0h Et0h commented Apr 19, 2020

Nice catch. I think you're probably right on both counts.

Et0h added a commit that referenced this issue May 16, 2020
@Et0h
Fix typo noted in #282
dafaf93
@Et0h Et0h closed this as completed May 16, 2020
albertosottile pushed a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
@Et0h @albertosottile
Fix typo noted in Syncplay#282
7cb2683
albertosottile pushed a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
@Et0h @albertosottile
Fix typo noted in Syncplay#282
3356b21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug / problem
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Et0h @siiky