Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{\\fscx0} appears when a " is sent in chat #329

Closed
KanchiMoe opened this issue Jun 24, 2020 · 1 comment
Closed

{\\fscx0} appears when a " is sent in chat #329

KanchiMoe opened this issue Jun 24, 2020 · 1 comment

Comments

@KanchiMoe
Copy link
Contributor

KanchiMoe commented Jun 24, 2020

Syncplay version: 1.6.5 release 86
Python: 3.6.8
Pyside2: 5.12.3
Qt 5.12.3

If you send, or recieve a message that has a double quote " in it, {\\fscx0} is added to the message.

Examples:

  • " produces {\\fscx0} "
  • x " y produces x {\\fscx0} " y
  • x " y " z produces x {\\fscx0} " y {\\fscx0} " z

This might be an issue with mpv, but I'm not too sure because of this line of code and because {\\fscx0} doesn't appear anywhere in MPV's repo.

I have also found this issue in libass: libass/libass/issues/185 which may be related, but I'm not sure.

@Et0h
Copy link
Contributor

Et0h commented Jun 25, 2020

Thanks for reporting this, it should be fixed now. The reason Syncplay uses {\fscx0} is because that is how we get get long messages to wrap properly. See mpv-player/mpv#4308 and mpv-player/mpv#2203 for discussions of the issue and workarounds to it.

There is now a minor glitch where if you use a " and a \ in the same chat message it will show \ rather than \ but that's an edge case which I don't want to spend time trying to fix. For now I guess you can just consider it an Easter egg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants