Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncplay now crashes when passing player arguments that worked fine before #333

Closed
alexbobp opened this issue Jul 8, 2020 · 2 comments
Closed

Comments

@alexbobp
Copy link

alexbobp commented Jul 8, 2020

It is common for my friends to keep the following in their player arguments field: --ytdl-format=bestvideo[height<=1080] in order to reduce bandwidth by not streaming youtube videos and the like in 4K. With the latest syncplay, these player arguments started causing immediate crashes of syncplay/mpv, even before any media attempts to load.

Specifically, we tested this on windows, using mpv.exe as the player.

I narrowed down the issue to the = character. Specifically, I can use --ytdl-format=bestvideo[height<1081] as a workaround. I hope this helps diagnose the bug.

@Spincervino
Copy link

Spincervino commented Sep 16, 2020

I have this problem too, removing the = sign from commands lets syncplay start normally.
Before version 1.6.4a i did not have the problem.

@Et0h
Copy link
Contributor

Et0h commented Sep 17, 2020

Thanks for reporting this issue. Is it resolved by f7ca631?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants