Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Make a server only package #375

Closed
tippl opened this issue Dec 28, 2020 · 8 comments
Closed

Suggestion: Make a server only package #375

tippl opened this issue Dec 28, 2020 · 8 comments
Assignees
Labels

Comments

@tippl
Copy link

tippl commented Dec 28, 2020

I was setting up a server instance for Syncplay on a server. When i attempted to install the .deb package, the hard dependency on vlc/mpv makes the package manager want to install the whole dependency chain for that (X11 server among other things).

This is really not ideal when trying to install just the server, i don't want to install X11 on a headless machine somewhere in cloud. I solved this by repackaging the deb file and removing the vlc/mpv and pyside2 dependency.

My suggestion is, that there should be a server only package so that you don't have to repackage, but still get the benefits of using a package manager.

@Et0h
Copy link
Contributor

Et0h commented Dec 28, 2020

I believe the discussion at #335 is relevant, especially the comments by @daniel-123. Linux isn't my area, but my understanding is that if someone is willing to implement and maintain support for a server-only package then they are free to make a PR. You would probably want to wait for PR #374 to be resolved before trying to make a PR implementing this feature, though.

@daniel-123 daniel-123 self-assigned this Dec 28, 2020
@daniel-123
Copy link
Contributor

Because you are second person to ask about this, I actually think that there is enough demand for such package to bother me enough to get around and make it.

Though like @Et0h said - we are currently right in the middle of migrating entire CI process over to different provider in #374 so this will have to wait.

Right now I'm thinking of simply making a no-gui version since that's only matter of removing dependencies and won't require any significant modification to the build script: https://github.com/Syncplay/syncplay/blob/master/travis/deb-script.sh

Last tidbit I'd mention is that server code hasn't been really touched for a good while. Only change it had in recent years is adding TLS support and that's it.

@Et0h
Copy link
Contributor

Et0h commented Jan 11, 2021

Update: PR #374 has been merged (so should hopefully no longer be an impediment to development). The deb-script file mentioned by @daniel-123 is now at https://github.com/Syncplay/syncplay/blob/master/ci/deb-script.sh

@Morsine
Copy link

Morsine commented Jan 12, 2021

I've been looking for such thing as well!

@tcyrus
Copy link

tcyrus commented Jan 22, 2021

I made a server-only fork of syncplay (removed all the client code) a while back. It isn't neat, and I changed a large chunk of the code to work with my specific use case, but it's here if you want it.

@daniel-123
Copy link
Contributor

@Morsine @tippl I've made a pull request with server package. Could you test the results? You can download the zip with both server and full packages here: https://github.com/Syncplay/syncplay/suites/1888847905/artifacts/36933740

The package is architecture independent, so it will work on Raspberry Pi as is.

@tippl
Copy link
Author

tippl commented Jan 24, 2021

@daniel-123 Just tested it on my server. Works great, does not require the gui packages, starts and i'm able to connect to it. I see no issues with it.

@daniel-123
Copy link
Contributor

Implemented in #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants