Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-down list with media players at start #398

Closed
MarisKori opened this issue Mar 6, 2021 · 7 comments
Closed

Drop-down list with media players at start #398

MarisKori opened this issue Mar 6, 2021 · 7 comments
Labels

Comments

@MarisKori
Copy link

It would be great if a user can choose media players when starting the application.
Also it would be doubly great if Syncplay could automatically find media players (e.g. using standard paths or using registry).

@daniel-123
Copy link
Contributor

daniel-123 commented Mar 6, 2021

Normally Syncplay already does search for compatible media players in default paths and displays them in a dropdown list.

Could you describe in details the situation were it apparently doesn't work? In particular:

  • What operating system you are using and what version of Syncplay.
  • Which players you have installed and in what paths.
  • What exactly was the process in which you started the Syncplay and concluded that it doesn't have this feature? This might seem like a silly question, but it's important for us to know in what exact way the user interface has misled you. We cannot really make such observations ourselves given that we know the software inside and out, so a new perspective is invaluable.

@MarisKori
Copy link
Author

  1. Windows 7 x64; Syncplay 1.6.7 (release 94)
  2. a) C:\Program Files\MPC-HC\mpc-hc64.exe
    b) C:\Program Files (x86)\VideoLAN\VLC\vlc.exe
    с) C:\Program Files (x86)\K-Lite Codec Pack\MPC-HC64\mpc-hc64.exe (friend's)
  3. It was Start menu, i.e. explorer.exe I guess.

Seems Syncplay saves previous path if I changed it. So yes, I can confirm that there is drop-down list. But I'm not sure how to check now what was at the beginning.

@Et0h
Copy link
Contributor

Et0h commented Mar 6, 2021

I think that as per https://syncplay.pl/guide/client/ you can run Syncplay with the --clear-gui-data switch to reset this data.

According to https://github.com/Syncplay/syncplay/blob/master/syncplay/constants.py the first two paths you specified should be listed by default. For K-Lite we didn't have the 64-bit version so I'll add that

Et0h added a commit that referenced this issue Mar 6, 2021
@daniel-123
Copy link
Contributor

daniel-123 commented Mar 6, 2021

It was Start menu, i.e. explorer.exe I guess.

@MarisKori sorry, I guess I didn't state my question clearly and simply :) I just wanted to know what you, as an end user, saw in the Syncplay window, what you clicked, what you checked etc. In essence I would like to get a perspective of why you thought that Syncplay doesn't have a list of existing players. Such description could also help us in actually reproducing the bug (as it does look like one).

Like at @Et0h mentioned - the dropdown should be there and it should have shown first two players you had. Possibly including additional custom path you set in the past. It's also possible that UI is simply not clear about what's happening, which in turn leads to bad user experience and confusion.

EDIT:
I just noticed that you marked third player path as "friend's". Am I correct in assuming that's the only player path they had on their system? If that's the case the entire problem boils down to Syncplay not being aware that MPC-HC can be found in K-Lite folder, which is easy to fix.

@MarisKori
Copy link
Author

Friend is sure that there was no drop-down list.

I guess that I personally could miss it but I remember too that there was no drop-down list.

I can check it again and even make a video if you tell me how to make Syncplay forget previously chosen paths. I think it's smart desision to save all typed paths but now I can't help you to test it.

Btw the friend (a girl) chose unins000.exe by mistake and Syncplay saved it's path. It's a kind of issue.

@daniel-123
Copy link
Contributor

@MarisKori like Et0h mentioned, you can use command line option --clear-gui-data to reset whatever is in that dropdown menu. I think on Windows the easiest way to do that is to make a temporary shortcut to Syncplay executable and add that option to "Target" field.

It would be great if you also managed to test latest development version of Syncplay after the change Et0h made - it should detect all the paths you listed earlier. You can download it here.

@MarisKori
Copy link
Author

I checked 1.6.7 and 1.6.8 versions (reinstalled it). There is drop-down list in both versions. Sorry for the wrong suggestion.

Btw I found syncplay.ini directly in C:\Users\user\AppData\Roaming.
I think there should be a subfolder like "C:\Users\user\AppData\Roaming\Syncplay" or "C:\Users\user\AppData\Roaming\TeamName". But it doesn't really matter.

Et0h added a commit that referenced this issue Aug 2, 2021
* Create pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Do not show playback speed change notifications in OSD

* Upbuild and remove debug message

* Strip quotation marks from per-player arguments (#226)

* Delete unmaintained changelog.

Removing old and unmaintained changelog file.

* Add more MPC-HC paths (#398)

* Migrate from AppVeyor to GitHub Actions (#399)

* Disable AppVeyor

* Actions: disable other jobs

* Actions: implement windows job

* Use requirements

* Typo in version parser

* Replace type nul for PowerShell

* Change Python version to 3.7

* buildPy2exe: exclude tcl and tkinter

* buildPy2exe: rename zip archive to include extension

* Actions for Windows: build on Python 3.8

* Re-enable build flow for other platforms

* Remove AppVeyor configuration file

* Add manpages courtesy of Bruno Kleinert #387

* Install the manpages.

* Separate debian package artifacts

Make it so that server and full packages are separate artifacts in CI rather than single zip containing both.

* Fix server deb deployment name in CI workflow

* Fix package filename for debs

* Update mpv json ipc vendor code

Update to version 1.1.13 to hopefully address #322 fully.

* Update setup.py for vendor code of mpv jsonipc

* Build AppImage on Ubuntu 18.04

Temporary workaround for AppImage built on Ubuntu 20.04 crashing with segmentation fault. #401

* Update python_mpv_jsonipc to 1.1.13 keeping our changes

* Remove the AppVeyor badge as we stopped using it.

* Improve playlist advancement for VLC and mpv (#334) (#397)

* Advance playlist on end of file in mpv and VLC
* Update duration for streams to fix playlist advancement (#334)

* Add notice for Python in third party collection file (#404)

* Add notice for Python in third party collection file

* Convert third party notices file to plain text

* Adapt codebase to third party notices format change

* Mark as beta 1 (release 97)

* Mark as 1.6.8 final (build 98)

* Update pt_BR translation, fix typo (#422)

* Bundle libgthread-2.0.so.0 into AppImage

* add libxcb manually

* Add missing libxcb-util to build environment

* Enable GitHub Actions on pull requests

* Bundle libxcb1 into AppImage to fix #380

* Send 32-bit/64-bit context when updating

* Upver to 1.6.9 release 99

* Remove references to IRC (#430)

* Add reference to GitHub discussions

* Update issue templates

* Revert "Merge branch 'master' into master"

This reverts commit 173007e, reversing
changes made to 6105da8.

Co-authored-by: Daniel Wróbel <wrobel.dan@gmail.com>
Co-authored-by: Alberto Sottile <alby128@gmail.com>
Co-authored-by: Daniel Wróbel <1662391+daniel-123@users.noreply.github.com>
Co-authored-by: Atílio Antônio <atiliodadalto@hotmail.com>
Co-authored-by: Teoh Han Hui <teohhanhui@gmail.com>
Co-authored-by: Alberto Sottile <asottile@gmail.com>
Co-authored-by: Assistant <assistant.moetron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants