Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitivity in room list #403

Closed
pabter opened this issue Mar 19, 2021 · 2 comments
Closed

Case sensitivity in room list #403

pabter opened this issue Mar 19, 2021 · 2 comments

Comments

@pabter
Copy link

pabter commented Mar 19, 2021

Whenever one connects to a server, room names are case sensitive (ie. the room "aRoom" is different from "aroom").
However, the saved room list is not case sensitive, and it keeps the casing from the first time a room was entered.

Thereferore, if one were to try to enter the room "aRoom", and mistakenly wrote "aroom", it would go to a different room (as expected), but when trying to correct the mistake to enter "aRoom", as "aroom" is already in the room list, it would keep entering "aroom", even when explictly typing "aRoom" in the "Default room:" field.

A solution for this is manually removing "aroom" from the room list, but i think the default behavior should be for it to save the room names remembering their casing.

(Also, does the question mark button on the room list window title bar do anything?)

@Et0h
Copy link
Contributor

Et0h commented Mar 19, 2021

Thanks for raising this issue as I was unaware of it. I think it should be possible to fix this by moving to a case-sensitive completer for the comboboxes.

The question mark on the room list doesn't do anything. I think it just means I haven't set the WindowFlags for that window to set Qt.WindowContextHelpButtonHint to false.

@Et0h
Copy link
Contributor

Et0h commented Oct 18, 2021

Sorry for the wait but both issues should now be resolved in Syncplay 1.7.0.

@Et0h Et0h closed this as completed Oct 18, 2021
Et0h added a commit that referenced this issue Oct 27, 2021
* Create pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* add libxcb manually

* Add missing libxcb-util to build environment

* Remove references to IRC (#430)

* Add reference to GitHub discussions

* Update issue templates

* Revert "Merge branch 'master' into master"

This reverts commit 173007e, reversing
changes made to 6105da8.

* Make Windows build 32-bit

* Support for LAV Filters Megamix (#457)

* Upver to 1.7.0 (r100)

* Refactor MPC-HC player path code (#453)

* Add LANG Parameter (#460)

If LANG parameter set, don't show language dialog.
Example usage: .\Syncplay-X.X.X-Setup.exe /S /LANG=1033

* Trusted Domains: Allow trusting a domain regardless of HTTP basic auth credentials (#437)

* Trusted Domains: don't consider HTTP basic auth credentials part of the domain name

* Trusted Domains: hide "add as trusted domain" menu item if entry does not contain domain

* Trusted Domains: strip HTTP basic auth credentials also when adding as trusted domain via context menu

* Allow .m3u/.m3u8 files to be played from network (#419)

* Fix room name case sensitivity UI issue (#403)

* Remove redundant help button from dialogs (#403)

* darkdetect: update vendor copy to 0.5.0

* macOS build: upgrade to Python 3.9 and PySide2 5.15.2

* Remove Encoding from .desktop files as it's depreciated now.

* Add Keywords entry to .desktop files.

* Console: Document setting offset in help (#435)

* Add deprecation notice for offset help (#435)

* Begin move from m3u/m3u8 to txt for playlist (#408)

Co-authored-by: Daniel Wróbel <wrobel.dan@gmail.com>
Co-authored-by: daniel-123 <1662391+daniel-123@users.noreply.github.com>
Co-authored-by: Assistant <assistant.moetron@gmail.com>
Co-authored-by: ImportTaste <53661808+ImportTaste@users.noreply.github.com>
Co-authored-by: Ata Gülalan <xava@hotmail.com.tr>
Co-authored-by: Tremolo4 <Tremolo4@users.noreply.github.com>
Co-authored-by: Ridan Vandenbergh <RidanVandenbergh@gmail.com>
Co-authored-by: Alberto Sottile <alby128@gmail.com>
Co-authored-by: Luke Dashjr <luke_github1@dashjr.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants