Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAV Filters Megamix mpc-hc filename #453

Closed
God-damnit-all opened this issue Aug 8, 2021 · 5 comments · Fixed by #457
Closed

LAV Filters Megamix mpc-hc filename #453

God-damnit-all opened this issue Aug 8, 2021 · 5 comments · Fixed by #457
Labels
enhancement Windows

Comments

@God-damnit-all
Copy link
Contributor

I use the following fairly popular codec pack: https://www.videohelp.com/software/LAV-Filters-Megamix

Something strange that it does is its filename for the main mpc-hc executable is different. Instead of mpc-hc.exe it's shoukaku.exe

I got around this issue by making a symbolic link of shoukaku.exe in the same directory it was in and named it mpc-hc.exe and pointed syncplay at it, which worked fine. But it would be convenient if syncplay recognized this filename by default.
@Et0h
Copy link
Contributor

Et0h commented Aug 9, 2021 •
edited
Loading

Adding shoukaku.exe shouldn't be a problem. Are the default full paths for it: C:\Program Files (x86)\LAV Filters\x64\mpc-hc\shoukaku.exe and c:\program files (x86)\lav filters\x86\mpc-hc\shoukaku.exe?

@God-damnit-all
Copy link
Contributor Author

Adding shoukaku.exe shouldn't be a problem. Are the default full paths for it: C:\Program Files (x86)\LAV Filters\x64\mpc-hc\shoukaku.exe and c:\program files (x86)\lav filters\x86\mpc-hc\shoukaku.exe?

Yes, that's correct. Thanks!

@God-damnit-all
Copy link
Contributor Author

@Et0h Heads up, I downloaded mpc-hc 1.9.15 today (the .zip one) and I noticed that the executable for the 64-bit version was named mpc-hc64.exe. Not sure if the setup version does the same thing, but regardless, mpc-hc64.exe should be added to the whitelist as well.

@God-damnit-all God-damnit-all mentioned this issue Aug 22, 2021
Merged
@Et0h Et0h closed this as completed in #457 Aug 29, 2021
Et0h added a commit that referenced this issue Aug 29, 2021
@Et0h
Refactor MPC-HC player path code (#453)
d71b7fc
@Et0h
Copy link
Contributor

Et0h commented Aug 29, 2021

I accepted the change but I've also now refactored the code to make it easier to add more filenames in the future. Please test the refactored version and confirm that it works.

@God-damnit-all
Copy link
Contributor Author

Seems to work fine, thanks.

Et0h added a commit that referenced this issue Oct 27, 2021
@Et0h @daniel-123
@Assistant @God-damnit-all @atagulalan @Tremolo4 @zeroeightysix @albertosottile @luke-jr
Rebase to main branch (#474)
91cf6a8 
* Create pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* Update pythonpackage.yml

* add libxcb manually

* Add missing libxcb-util to build environment

* Remove references to IRC (#430)

* Add reference to GitHub discussions

* Update issue templates

* Revert "Merge branch 'master' into master"

This reverts commit 173007e, reversing
changes made to 6105da8.

* Make Windows build 32-bit

* Support for LAV Filters Megamix (#457)

* Upver to 1.7.0 (r100)

* Refactor MPC-HC player path code (#453)

* Add LANG Parameter (#460)

If LANG parameter set, don't show language dialog.
Example usage: .\Syncplay-X.X.X-Setup.exe /S /LANG=1033

* Trusted Domains: Allow trusting a domain regardless of HTTP basic auth credentials (#437)

* Trusted Domains: don't consider HTTP basic auth credentials part of the domain name

* Trusted Domains: hide "add as trusted domain" menu item if entry does not contain domain

* Trusted Domains: strip HTTP basic auth credentials also when adding as trusted domain via context menu

* Allow .m3u/.m3u8 files to be played from network (#419)

* Fix room name case sensitivity UI issue (#403)

* Remove redundant help button from dialogs (#403)

* darkdetect: update vendor copy to 0.5.0

* macOS build: upgrade to Python 3.9 and PySide2 5.15.2

* Remove Encoding from .desktop files as it's depreciated now.

* Add Keywords entry to .desktop files.

* Console: Document setting offset in help (#435)

* Add deprecation notice for offset help (#435)

* Begin move from m3u/m3u8 to txt for playlist (#408)

Co-authored-by: Daniel Wróbel <wrobel.dan@gmail.com>
Co-authored-by: daniel-123 <1662391+daniel-123@users.noreply.github.com>
Co-authored-by: Assistant <assistant.moetron@gmail.com>
Co-authored-by: ImportTaste <53661808+ImportTaste@users.noreply.github.com>
Co-authored-by: Ata Gülalan <xava@hotmail.com.tr>
Co-authored-by: Tremolo4 <Tremolo4@users.noreply.github.com>
Co-authored-by: Ridan Vandenbergh <RidanVandenbergh@gmail.com>
Co-authored-by: Alberto Sottile <alby128@gmail.com>
Co-authored-by: Luke Dashjr <luke_github1@dashjr.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for LAV Filters Megamix God-damnit-all/syncplay
3 participants
@daniel-123 @Et0h @God-damnit-all