New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --force-window and --idle=once with mpv #53

Closed
wiiaboo opened this Issue Feb 10, 2015 · 10 comments

Comments

Projects
None yet
3 participants
@wiiaboo
Contributor

wiiaboo commented Feb 10, 2015

Allows Syncplay to open mpv without having a media file ready:

@Uriziel

This comment has been minimized.

Show comment
Hide comment
@Uriziel

Uriziel Feb 10, 2015

Contributor

This is cool.

Contributor

Uriziel commented Feb 10, 2015

This is cool.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Feb 10, 2015

Contributor

Nice one. I'll look into that when I am next free. The important question is the version when the features were added to mpv so Syncplay knows when to use the functionality.

Contributor

Et0h commented Feb 10, 2015

Nice one. I'll look into that when I am next free. The important question is the version when the features were added to mpv so Syncplay knows when to use the functionality.

@wiiaboo

This comment has been minimized.

Show comment
Hide comment
@wiiaboo

wiiaboo Feb 10, 2015

Contributor

--force-window in 0.2.0, --idle=once hasn't been applied to 0.7.3, I think? but --idle has been there since mplayer, so the safest way to use would be --idle=yes, I guess. At least until 0.8.0 gets released.

Contributor

wiiaboo commented Feb 10, 2015

--force-window in 0.2.0, --idle=once hasn't been applied to 0.7.3, I think? but --idle has been there since mplayer, so the safest way to use would be --idle=yes, I guess. At least until 0.8.0 gets released.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Feb 10, 2015

Contributor

Thanks for the intel. We try to maintain backwards compatibility within Syncplay so this kind of information is rather useful. Using newer functionality is fine so long as there is graceful fallback.

Contributor

Et0h commented Feb 10, 2015

Thanks for the intel. We try to maintain backwards compatibility within Syncplay so this kind of information is rather useful. Using newer functionality is fine so long as there is graceful fallback.

@wiiaboo

This comment has been minimized.

Show comment
Hide comment
@wiiaboo

wiiaboo Feb 15, 2015

Contributor

Just --idle seems to work too, so it's probably safe to use that.

Contributor

wiiaboo commented Feb 15, 2015

Just --idle seems to work too, so it's probably safe to use that.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Feb 16, 2015

Contributor

Try a795aca and let me know if it works or if it causes any problems.

Contributor

Et0h commented Feb 16, 2015

Try a795aca and let me know if it works or if it causes any problems.

@wiiaboo

This comment has been minimized.

Show comment
Hide comment
@wiiaboo

wiiaboo Feb 16, 2015

Contributor

Seems to be working fine. I'll try a few episodes with friends tomorrow.

Contributor

wiiaboo commented Feb 16, 2015

Seems to be working fine. I'll try a few episodes with friends tomorrow.

Et0h added a commit that referenced this issue Feb 16, 2015

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Feb 16, 2015

Contributor

Cheers. Quick fix to a bug introduced by the previous commit: fd6d157

Contributor

Et0h commented Feb 16, 2015

Cheers. Quick fix to a bug introduced by the previous commit: fd6d157

@wiiaboo

This comment has been minimized.

Show comment
Hide comment
@wiiaboo

wiiaboo Mar 17, 2015

Contributor

No bugs so far. I think it's safe to close this?

Contributor

wiiaboo commented Mar 17, 2015

No bugs so far. I think it's safe to close this?

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Mar 25, 2015

Contributor

Yup, all seems good. Thanks for your contribution :)

Contributor

Et0h commented Mar 25, 2015

Yup, all seems good. Thanks for your contribution :)

@Et0h Et0h closed this Mar 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment