Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --force-window and --idle=once with mpv #53

Closed
wiiaboo opened this issue Feb 10, 2015 · 10 comments
Closed

Use --force-window and --idle=once with mpv #53

wiiaboo opened this issue Feb 10, 2015 · 10 comments

Comments

@wiiaboo
Copy link
Contributor

@wiiaboo wiiaboo commented Feb 10, 2015

Allows Syncplay to open mpv without having a media file ready:

@Uriziel
Copy link
Contributor

@Uriziel Uriziel commented Feb 10, 2015

This is cool.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Feb 10, 2015

Nice one. I'll look into that when I am next free. The important question is the version when the features were added to mpv so Syncplay knows when to use the functionality.

@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Feb 10, 2015

--force-window in 0.2.0, --idle=once hasn't been applied to 0.7.3, I think? but --idle has been there since mplayer, so the safest way to use would be --idle=yes, I guess. At least until 0.8.0 gets released.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Feb 10, 2015

Thanks for the intel. We try to maintain backwards compatibility within Syncplay so this kind of information is rather useful. Using newer functionality is fine so long as there is graceful fallback.

@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Feb 15, 2015

Just --idle seems to work too, so it's probably safe to use that.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Feb 16, 2015

Try a795aca and let me know if it works or if it causes any problems.

@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Feb 16, 2015

Seems to be working fine. I'll try a few episodes with friends tomorrow.

Et0h added a commit that referenced this issue Feb 16, 2015
@Et0h
Copy link
Contributor

@Et0h Et0h commented Feb 16, 2015

Cheers. Quick fix to a bug introduced by the previous commit: fd6d157

@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Mar 17, 2015

No bugs so far. I think it's safe to close this?

@Et0h
Copy link
Contributor

@Et0h Et0h commented Mar 25, 2015

Yup, all seems good. Thanks for your contribution :)

@Et0h Et0h closed this Mar 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.