Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Tries to run /Application/VLC.app #91
I follow the instructions to install syncplay.
After some exploration syncplay tries to run
I don't know the reason for this to happen or if you don't consider a problem but when I go back and select the complete path of VLC it works. I'm not used to how mac works but I would assume that some people will find the error and it is just an UI issue, to make it clear that you have to select the full path of the binary or to deduce the path of the binary.
My bad, that is not the issue. The issue is that Syncplay chooses
When I click in the arrow right to the textbox THEN I see the full path as an option.
Steps to reproduce:
All in all is just an UI/Usability issue.
As a python newbie what happened to me is that I saw the error in the terminal first, then I saw that mpv didn't have that problem at all. So went and compared the code of both classes in the Syncplay code until I figured out that both players VLC and mpv have the same code for expanding the path so it couldn't be something that the player Factory or anything like that could be doing (I avoid UI code as much as I can) and decided to make this ticket and THEN I saw the drop down arrow where the full path of VLC was instead of the short one that have been plaguing me.
Thanks for bringing this issue to light. I've mentioned this problem at #81 so hopefully we'll find someone who will be able to code and test a fix for this. For people who use a Mac and know Python I'm guessing it won't be too hard to solve based on your suggested expected behaviour. If it is possible, just correcting the location as appropriate would be nicer than having to give a warning.