New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpv bugfixes #106

Merged
merged 2 commits into from Oct 17, 2016

Conversation

Projects
None yet
4 participants
@wiiaboo
Contributor

wiiaboo commented Aug 1, 2016

scaletempo is also not useful with the small changes in playback rate from the slowing down in Syncplay. They're small enough to be more noticeable with it than without, like with interpolation+display-sync.
Besides, mpv has --audio-pitch-correction enabled by default which automatically adds scaletempo when needed.

wiiaboo added some commits Aug 1, 2016

mpv: remove scaletempo filter
With interpolation and display-sync this ruins the audio.
Let the user decide if they want that or not.
@wiiaboo

This comment has been minimized.

Show comment
Hide comment
@wiiaboo

wiiaboo Sep 19, 2016

Contributor

--audio-pitch-correction was introduced in v0.9.0 and since then mpv has always dynamically added scaletempo as needed.

Contributor

wiiaboo commented Sep 19, 2016

--audio-pitch-correction was introduced in v0.9.0 and since then mpv has always dynamically added scaletempo as needed.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Oct 17, 2016

Contributor

The change sounds like a good idea - I've assigned Dan to review the PR.

Contributor

Et0h commented Oct 17, 2016

The change sounds like a good idea - I've assigned Dan to review the PR.

@Uriziel Uriziel merged commit 53d9c2a into Syncplay:master Oct 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment