New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to setup GUI, iff noGui is False #117

Merged
merged 1 commit into from Oct 19, 2016

Conversation

Projects
None yet
2 participants
@Hummer12007
Contributor

Hummer12007 commented Oct 13, 2016

This prevents the import error message from being displayed when GUI is
disabled on systems without PySide

Additionally, remove some redundant conditionals

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Oct 16, 2016

Contributor

Will need to test this before it is merged, but thanks for your contribution. It is definitely desirable to allow those without PySide to use the command line interface version of Syncplay.

Contributor

Et0h commented Oct 16, 2016

Will need to test this before it is merged, but thanks for your contribution. It is definitely desirable to allow those without PySide to use the command line interface version of Syncplay.

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Oct 19, 2016

Contributor

Only quickly tried to test, but I couldn't get it to work. It seems that when you run it and then have GuiConfig load by default and then run Syncplay from GuiConfig it adds an additional :8996 to the end of the host/ports which causes Syncplay to fail to connect.

Not sure, but I think it is related to the fact that the new code causes _validateArguments to be called twice BEFORE the GuiConfig dialogue is closed and not at all afterwards.

Have you tested it with forceGuiPrompt being true in your config file and PySide installed?

Contributor

Et0h commented Oct 19, 2016

Only quickly tried to test, but I couldn't get it to work. It seems that when you run it and then have GuiConfig load by default and then run Syncplay from GuiConfig it adds an additional :8996 to the end of the host/ports which causes Syncplay to fail to connect.

Not sure, but I think it is related to the fact that the new code causes _validateArguments to be called twice BEFORE the GuiConfig dialogue is closed and not at all afterwards.

Have you tested it with forceGuiPrompt being true in your config file and PySide installed?

Try to setup GUI, iff noGui is False
This prevents the error message from being displayed when GUI is
disabled on systems without PySide

Additionally, remove some redundant conditionals

@Et0h Et0h merged commit 4d428ae into Syncplay:master Oct 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment