Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mpv without length property #120

Merged
merged 2 commits into from Nov 24, 2016
Merged

Support mpv without length property #120

merged 2 commits into from Nov 24, 2016

Conversation

@wiiaboo
Copy link
Contributor

@wiiaboo wiiaboo commented Nov 23, 2016

The 'length' property was deprecated since then and will be gone
with 0.23.0 and is already gone in git master, so Syncplay is
broken with it.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Nov 23, 2016

@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Nov 23, 2016

If they're using a more-than-a-year-old mpv then they can use a more-than-a-year-old Syncplay too.

@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Nov 23, 2016

This is the commit that deprecated it, from May 2015: mpv-player/mpv@d26803c

@Et0h
Copy link
Contributor

@Et0h Et0h commented Nov 24, 2016

wiiaboo added 2 commits Nov 24, 2016
This allows using both length and duration. mpv will fallback to
duration if length isn't available. If neither are available, it
falls back to 0 which doesn't break Syncplay and happens to add
support for livestreams.
@wiiaboo wiiaboo changed the title Require at least mpv 0.10.0 Support mpv without length property Nov 24, 2016
@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Nov 24, 2016

Hey, turns out we can use both. And livestreams/files with unknown durations work now.
I also tried with a pre-deprecation build to make sure it worked.

@Et0h
Copy link
Contributor

@Et0h Et0h commented Nov 24, 2016

Excellent ^_^

@Et0h Et0h closed this Nov 24, 2016
@wiiaboo
Copy link
Contributor Author

@wiiaboo wiiaboo commented Nov 24, 2016

Merged locally?

@Et0h
Copy link
Contributor

@Et0h Et0h commented Nov 24, 2016

Just a sec...

@Et0h Et0h reopened this Nov 24, 2016
@Et0h Et0h merged commit 734efae into Syncplay:master Nov 24, 2016
@wiiaboo wiiaboo deleted the wiiaboo:mpv_fix branch Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.