Support mpv without length property #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this change to Syncplay breaks backwards compatability then it raises
the question of whether it can be modified to maintain backwards
compatability, e.g. by having different behaviours for different versions.
|
|
If they're using a more-than-a-year-old mpv then they can use a more-than-a-year-old Syncplay too. |
|
This is the commit that deprecated it, from May 2015: mpv-player/mpv@d26803c |
|
Whilst I would rather everyone ran the latest versions of software I also
aim to maximise backwards compatability. As such, I would be reluctant to
opt for a change that broke backwards compatability when an alternative
which maintained backwards compatibility required little additional effort
and had no adverse side effects.
Of course, forwards compatibility is also very important so thanks for
proposing this change. I shall look into resolving the pull request when I
return from my holiday in a few days if neither Uriziel nor Dan has
resolved it by then.
|
This allows using both length and duration. mpv will fallback to duration if length isn't available. If neither are available, it falls back to 0 which doesn't break Syncplay and happens to add support for livestreams.
wiiaboo
changed the title
|
Hey, turns out we can use both. And livestreams/files with unknown durations work now. |
|
Excellent ^_^ |
|
Merged locally? |
|
Just a sec... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'length' property was deprecated since then and will be gone
with 0.23.0 and is already gone in git master, so Syncplay is
broken with it.