Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents App Nap on macOS 10.9+ #143

Merged
merged 1 commit into from Sep 10, 2017
Merged

Prevents App Nap on macOS 10.9+ #143

merged 1 commit into from Sep 10, 2017

Conversation

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Sep 7, 2017

Solves #116 and #60 (finally).
Adds a new dependency: appnope (GitHub), required only on macOS. It is available on pip. If merged, I guess the installation instructions have to be updated accordingly.

(Note: please be patient if I did something horribly wrong since this is my first pull request.)

@albertosottile albertosottile force-pushed the albertosottile:master branch from 1814be5 to b4e114a Sep 7, 2017
@Et0h
Copy link
Contributor

@Et0h Et0h commented Sep 7, 2017

@albertosottile albertosottile reopened this Sep 7, 2017
@albertosottile
Copy link
Member Author

@albertosottile albertosottile commented Sep 7, 2017

Sorry, I had to close this briefly because I did something wrong in the fork. Now everything should be fine. I am open for questions if anyone wants to test this.

I can update the install instructions if you want, but I did not useconda. I am afraid we should switch to homebrew because it has the patched qt4 recipe needed for macOS 10.12. If you want, I can write some instructions that use homebrew.

Once this issue is fixed, we can start testing the .app packaging code. Thanks again.

@albertosottile
Copy link
Member Author

@albertosottile albertosottile commented Sep 8, 2017

I wrote a post with detailed instructions for the installation of Syncplay on macOS 10.8+ here:
http://www.albertosottile.it/syncplay/2017/09/08/install-syncplay-on-macos-10-8/

If you want, you can link it on the syncplay.pl website. I encourage everyone who wants to use Syncplay on macOS to follow these instructions so that we can test if this patch works.

@Et0h Et0h merged commit b97fdde into Syncplay:master Sep 10, 2017
@Et0h
Copy link
Contributor

@Et0h Et0h commented Sep 10, 2017

Cheers. The Syncplay website has been updated to link to your instructions. As the commit has now been merged the instructions should be updated to use the official Syncplay repo.

@albertosottile
Copy link
Member Author

@albertosottile albertosottile commented Sep 10, 2017

Done. I guess that issues #60, #112, and #116 should also be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.