-
Notifications
You must be signed in to change notification settings - Fork 223
Supporting for Italian translation. #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…outputheader-label
I am sorry, I did not notice that Travis CI builds were broken for syncplay/master. I just fixed this with the For @Et0h: for some reasons I did not get an email notification about the broken build on Travis, I am looking into this right now. Also, Travis is still deploying to version v1.5.1 on Bintray. I suggest to just get rid of versions on Bintray and stick with something like "stable" and "development", so that we do not have to update the bintray.json file everytime. |
55aae57
to
907904f
Compare
@alby128 Makes sense. Is that something you can change or do I need to do it? |
@alby128 No worries. It should be ok now. |
@Et0h I will just edit the "bintray.json" file to use "development" as version name. Then, we will just manually move the correct files in the "stable" version (that I will create manually) once they are ready. I think keeping one or two stable versions on bintray should be more than enough. Also, right now appveyor builds are failing because there is not enough space to upload artifacts. We have to delete some artifacts from the Syncplay's appveyor account, but unfortunately, I cannot do that from my own account. @Nico769 I will review the Italian translation in the next days. Thanks. |
@Nico769 I am reviewing the translation and I think it will be easier if you let me commit edits directly in your fork. Could you please enable the write access as described here: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ ? Thanks. |
@Et0h I need some help about this: Also, I would like to know what the "Hello" arguments are before attempting to translate the relative strings. |
@Et0h one more thing: |
@albertosottile The option is already enabled. |
@albertosottile Thanks for separating the messages. It was only for convenience that they were one message in the first place, but I can certainly see why it is worth splitting them to allow for more effective translation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review performed in the latest two commits.
The latest two commits conclude my review of the translation, nice work @Nico769. I will merge this PR as soon as I am able to re-test everything in the app. |
@albertosottile Thanks, you too! |
Added Italian translation
The entire application and its installer have been translated into Italian.
A hard coded label in ui/GuiConfiguration.py has been replaced by a new label
chatoutputheader-label
. Thus,self.chatOutputGroup = QtWidgets.QGroupBox(u"Chat message output")
is nowself.chatOutputGroup = QtWidgets.QGroupBox(getMessage("chatoutputheader-label"))
.For clarity's sake,
chatoutputheader-label
has also been added to the others messages_xx.py