New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting for Italian translation. #176

Merged
merged 5 commits into from Feb 19, 2018

Conversation

Projects
None yet
3 participants
@Nico769
Copy link

Nico769 commented Feb 8, 2018

The entire application and its installer have been translated into Italian.

A hard coded label in ui/GuiConfiguration.py has been replaced by a new label chatoutputheader-label. Thus, self.chatOutputGroup = QtWidgets.QGroupBox(u"Chat message output") is now self.chatOutputGroup = QtWidgets.QGroupBox(getMessage("chatoutputheader-label")).

For clarity's sake, chatoutputheader-label has also been added to the others messages_xx.py

@Et0h Et0h requested a review from albertosottile Feb 8, 2018

@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Feb 9, 2018

I am sorry, I did not notice that Travis CI builds were broken for syncplay/master. I just fixed this with the 394fd6e commit. @Nico769 could you please update your fork (hence this PR) by adding this commit? Thanks. I will then review all the translated labels.

For @Et0h: for some reasons I did not get an email notification about the broken build on Travis, I am looking into this right now. Also, Travis is still deploying to version v1.5.1 on Bintray. I suggest to just get rid of versions on Bintray and stick with something like "stable" and "development", so that we do not have to update the bintray.json file everytime.

@Nico769 Nico769 force-pushed the Nico769:master branch 2 times, most recently from 55aae57 to 907904f Feb 9, 2018

@Et0h

This comment has been minimized.

Copy link
Contributor

Et0h commented Feb 9, 2018

@alby128 Makes sense. Is that something you can change or do I need to do it?

@Nico769 Nico769 force-pushed the Nico769:master branch from 4c3728b to 735c876 Feb 9, 2018

@Nico769

This comment has been minimized.

Copy link
Author

Nico769 commented Feb 9, 2018

@alby128 No worries. It should be ok now.

@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Feb 9, 2018

@Et0h I will just edit the "bintray.json" file to use "development" as version name. Then, we will just manually move the correct files in the "stable" version (that I will create manually) once they are ready. I think keeping one or two stable versions on bintray should be more than enough. Also, right now appveyor builds are failing because there is not enough space to upload artifacts. We have to delete some artifacts from the Syncplay's appveyor account, but unfortunately, I cannot do that from my own account.

@Nico769 I will review the Italian translation in the next days. Thanks.

@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Feb 13, 2018

@Nico769 I am reviewing the translation and I think it will be easier if you let me commit edits directly in your fork. Could you please enable the write access as described here: https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ ? Thanks.

@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Feb 13, 2018

@Et0h I need some help about this:
"mpv-key-tab-hint": u"[TAB] to toggle access to alphabet row key shortcuts.", # TODO needs to clarify this (line 261)
this:
"fastforwardondesync-tooltip" : "Jump forward when out of sync with room operator (or your pretend position if 'Never slow down or rewind others' enabled).", (line 371)
and this:
"not-known-server-error" : "You must be known to server before sending this command", (line 446).

Also, I would like to know what the "Hello" arguments are before attempting to translate the relative strings.

@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Feb 13, 2018

@Et0h one more thing:
Maybe we should avoid using syncplay-mediasearchdirectories-title also for the text above the input field and create a new label for it. Currently, this label is too long for the title bar but is fine for the dialog. EDIT: I already separated those labels in this PR.

@Nico769

This comment has been minimized.

Copy link
Author

Nico769 commented Feb 13, 2018

@albertosottile The option is already enabled.

@Nico769

This comment has been minimized.

Copy link
Owner

Nico769 commented on a88f5d6 Feb 13, 2018

Thanks for the review! It appears I missed some typos :)

@Et0h

This comment has been minimized.

Copy link
Contributor

Et0h commented Feb 14, 2018

@albertosottile Thanks for separating the messages. It was only for convenience that they were one message in the first place, but I can certainly see why it is worth splitting them to allow for more effective translation.

@albertosottile
Copy link
Member

albertosottile left a comment

Review performed in the latest two commits.

@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Feb 16, 2018

The latest two commits conclude my review of the translation, nice work @Nico769. I will merge this PR as soon as I am able to re-test everything in the app.

@Nico769

This comment has been minimized.

Copy link
Author

Nico769 commented Feb 16, 2018

@albertosottile Thanks, you too!

@albertosottile albertosottile merged commit a1c583b into Syncplay:master Feb 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

albertosottile added a commit to albertosottile/syncplay that referenced this pull request Feb 20, 2018

Merge pull request Syncplay#176 from Nico769/master
Added Italian translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment