Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Transition to PySide2 and Qt 5.x #185
This PR contains the migration of Syncplay to PySide2, following the discussion of issue #152.
While it is true that PySide2 (side note: the official name is now Qt for Python) has not been officially released yet, the binding is stable enough for beta testing its behavior with Syncplay. Furthermore, in view of the upcoming dismissal of Python 2, we need to accelerate the transition to Qt 5. Ideally, once this PR is merged, we will release a beta 1.5.4 version to allow extensive tests of Syncplay on Qt 5 on all the platforms.
Despite the large number of commits indicated by GitHub, only the packaging files are changed in this PR, while the Syncplay code is actually the same as in current master, thanks to Qt.py (with the exception of a few tabs in ui/ConfigurationGetter.py).
The code in this PR updates the packaging CI systems as detailed hereafter:
Incidentally, this PR solves issue #149.
Side note: I tried to embed the PySide2 official wheels on Windows, but they are not releasing them for x86 and, as far as I know, there are no wheels for py2exe_py2 for win_amd64. So, for the moment, we are stuck with conda packages. We could attempt this replacement after migrating the codebase to Python 3 and PyInstaller.
EDIT: I just found this in the Qt for Python Development Notes of this week
So, maybe there is still hope to have official wheels suitable for the current packaging of Syncplay for Windows.
Qt for Python was released today, as a technical preview (v5.11.0 TP), with some caveats:
In summary, this is the status of this PR for the three platforms: