Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete encode/decode calls #198

Merged
merged 1 commit into from Aug 3, 2018
Merged

Remove obsolete encode/decode calls #198

merged 1 commit into from Aug 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 2, 2018

This fixes the following error I'm seeing when I try to add URIs to the playlist on the current master version:

Traceback (most recent call last):
  File "/home/user/Projects/syncplay/syncplay/ui/gui.py", line 628, in <lambda>
    menu.addAction(QtGui.QPixmap(resourcespath + "world_add.png"), getMessage("addurlstoplaylist-menu-label"), lambda: self.OpenAddURIsToPlaylistDialog())
  File "/home/user/Projects/syncplay/syncplay/ui/gui.py", line 382, in wrapper
    return f(self, *args, **kwds)
  File "/home/user/Projects/syncplay/syncplay/ui/gui.py", line 979, in OpenAddURIsToPlaylistDialog
    URI = urllib.parse.unquote(URI)
  File "/usr/lib64/python3.6/urllib/parse.py", line 610, in unquote
    if '%' not in string:
TypeError: a bytes-like object is required, not 'str'

@albertosottile
Copy link
Member

Tested this on macOS, it solves the bug. Thank you for spotting and patching this.

@albertosottile albertosottile self-requested a review August 2, 2018 11:11
@Et0h Et0h self-requested a review August 3, 2018 18:10
Copy link
Contributor

@Et0h Et0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed the bug and the fix. Thank you for your contribution :)

@Et0h Et0h merged commit 2c2045b into Syncplay:master Aug 3, 2018
albertosottile pushed a commit to albertosottile/syncplay that referenced this pull request Aug 3, 2018
Remove obsolete encode/decode calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants