New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-environment-support #211

Merged
merged 1 commit into from Dec 16, 2018

Conversation

Projects
None yet
2 participants
@mordner
Copy link
Contributor

mordner commented Dec 16, 2018

For --password and --salt we now check the environment for the corresponding
variables SYNCPLAY_PASSWORD and SYNCPLAY_SALT. If they are found their values
are used as long as the options are not given via CLI.

Setting both options this way is highly encouraged. It fixes leaking these
secret options to other system users (e.g. on Linux everybody can see them
with 'ps' or looking at '/proc//cmdline'.

add-environment-support
For --password and --salt we now check the environment for the corresponding
variables SYNCPLAY_PASSWORD and SYNCPLAY_SALT. If they are found their values
are used as long as the options are not given via CLI.

Setting both options this way is highly encouraged. It fixes leaking these
secret options to other system users (e.g. on Linux everybody can see them
with 'ps' or looking at '/proc/<pid>/cmdline'.

@Et0h Et0h merged commit 73afb23 into Syncplay:master Dec 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mordner mordner deleted the mordner:add-environment-support branch Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment