New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 support #215

Merged
merged 12 commits into from Jan 30, 2019

Conversation

Projects
None yet
2 participants
@albertosottile
Copy link
Member

albertosottile commented Jan 27, 2019

Introduces the support for IPv6 in Syncplay (addressing issue #107).

The server now listens on both IPv4 and IPv6 protocols, if possible. The client should be able to connect to a server using both protocols. The user interfaces of the client (CLI and GUI) were updated to accept and parse correctly the standard notation for an IPv6 address + port number (e.g. [2001:db8::1]:8080).

albertosottile and others added some commits Nov 8, 2018

IPv6: use HostnameEndpoint in client for both IPv4 and IPv6
This change was originally introduced and then deleted.
Now is reintroduced after tests on both protocols.
HostnameEndpoint is needed in some configurations to resolve
IPv6-only hostnames, so it is required. The connection now works
with both protocols on clients and servers.

NOTE: now a wrong server/address/port DOES NOT trigger a Connection
with Server Failed error immediately, the error stays in Deferred.
This must be fixed before putting this code in production.

@albertosottile albertosottile merged commit bbc5ae0 into Syncplay:master Jan 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@albertosottile albertosottile referenced this pull request Jan 30, 2019

Closed

IPv6 Support #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment