Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opportunistic TLS support #223

Merged
merged 62 commits into from Feb 18, 2019
Merged

Opportunistic TLS support #223

merged 62 commits into from Feb 18, 2019

Conversation

albertosottile
Copy link
Member

@albertosottile albertosottile commented Feb 15, 2019

Addresses issue #217. Further details in the wiki and soon in the website.

It also supports a dual stack IPv4 and IPv6 listener on the server using Twisted endpoints and proper error handling.

Following the guidelines reported in the Twisted documentation
here https://twistedmatrix.com/documents/current/core/howto/ssl.html
this commit enables Diffie-Hellman based key exchange on the server.

Before launching the server, a parameters .pem file must be generated
as detailed in https://twistedmatrix.com/documents/18.9.0/api/twisted.internet.ssl.DiffieHellmanParameters.html
by running `openssl dhparam -out dh_param_1024.pem -2 1024`
on the server machine. This parameters file must be placed in the same
path that contains the server certificates.
albertosottile and others added 28 commits February 16, 2019 00:03
Following the guidelines reported in the Twisted documentation
here https://twistedmatrix.com/documents/current/core/howto/ssl.html
this commit enables Diffie-Hellman based key exchange on the server.

Before launching the server, a parameters .pem file must be generated
as detailed in https://twistedmatrix.com/documents/18.9.0/api/twisted.internet.ssl.DiffieHellmanParameters.html
by running `openssl dhparam -out dh_param_1024.pem -2 1024`
on the server machine. This parameters file must be placed in the same
path that contains the server certificates.
@crabdancing
Copy link
Contributor

I'm really excited for this revision. :D Finally we'll have secure connections! I just wanted to say I really appreciate your work. Thanks :3

@Et0h Et0h merged commit 14af13c into Syncplay:master Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants