Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translation and small fix on others #227

Merged
merged 7 commits into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@bcattaneo
Copy link
Contributor

bcattaneo commented Feb 24, 2019

No description provided.

@Et0h Et0h self-assigned this Feb 26, 2019

@Et0h

This comment has been minimized.

Copy link
Contributor

Et0h commented Feb 26, 2019

We have made a few tweaks to the strings for 1.6.3 that need to be reflected in your PR, but otherwise it is looking great to me. See changes to messages_en.py in aaf332b#diff-579494406d712737d7da6a6fe2e623c0 and f8ea238#diff-579494406d712737d7da6a6fe2e623c0

@bcattaneo

This comment has been minimized.

Copy link
Contributor Author

bcattaneo commented Feb 26, 2019

@Et0h Tested a4779d5 and looks good!, sent a missing translation (I forgot before) on 6f40a46 but I think it's all good.

@Et0h Et0h merged commit 276eed4 into Syncplay:master Feb 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

albertosottile added a commit to albertosottile/syncplay that referenced this pull request Feb 27, 2019

Add Spanish translation (Syncplay#227)
Add Spanish translation and small fix on others.

* Added missing languages in 'language-argument' and new 'es' language

* Small fix on 'unpause-ifothersready-tooltip'

* Adds Spanish translation to Syncplay and its installer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.