-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setup.py for setuptools #230
Conversation
Amended syncplay.utils.findWorkingDir for the setuptools path
Thank you for this PR, we really appreciate it. We are currently working on implementing Firstly, you used Secondly, you found a way to install the scripts without restructuring the package, by subclassing the Thirdly, you subclassed In summary, I think we will reject this PR in favor of opening a new one, based on the work done so far in the fork linked above. I sincerely apologize for the time you already invested in working on this. In any case, I strongly encourage to review and contribute to the upcoming PR, since you seem very experienced with |
Thank you for the response. That's all right, I just did it in an evening as a proof of concept mostly. I wasn't aware that you were already working on it in a fork. I'll be glad to offer my help, though I'm not really very experienced. |
* setuptools: Initial commit * setuptools: remove the .py extension from installed commands * setuptools: restructure scripts to use entry_points in setup.py * setuptools: include TLS dependencies and remove unneeded code * setuptools: change resources path * AppVeyor: upgrade Python and py2exe, embed TLS dependencies * buildpy2exe: fix path for resources * AppVeyor: upgrade py2exe and PySide2 * Amend setup.py according to the suggestions from PR #230 * Insert TLS dependencies in requirements * AppVeyor: fix build for master * AppVeyor: revert to PySide2 5.12.0
Closed as setuptools is now supported via #231 |
This is related to issue #207.
I tried to keep changes to the codebase minimal but I had to edit
syncplay.utils.findWorkingDir
to find the path when installed viasetuptools
sinceresources/
is copied intosyncplay/
.(You could probably use pkg_resources to load resources and avoid all the hassle.)
Once Syncplay is deployed to PyPI (which can be automated by Travis), installing it along with its optional dependencies will be as simple as
pip3 install syncplay[gui,tls]
.Environment info:
Antergos Linux 5.0.3-arch1-1-ARCH
Python 3.7.2
pip 18.1
setuptools 40.8.0