Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config dialog: Remove 'update list' button and tweak sizes #233

Merged
merged 3 commits into from May 1, 2019

Conversation

Projects
None yet
2 participants
@Et0h
Copy link
Contributor

commented Apr 13, 2019

This PR removes the 'update server list' and changes some of the GUI heights/widths to make it look tidier.

We don't have third party servers at the moment and it checks for them when it looks for updates anyway, so I think the button is unnecessary clutter at present.

Removing it meant we didn't need so much width, but I also noticed that reworking the code then meant the height was a bit short in non-advanced mode on some DPIs so I made it taller for text not to be clipped off in the input boxes.

The tweak also ensures that the executable path input box is aligned with those from the other group box, to avoid an issue where in non-advanced mode it was a bit too far to the left.

I've only tested this on Windows, so if you can test this on other OS to see if the GuiConfig looks okay then that would be appreciated!

@Et0h Et0h merged commit ca9e187 into master May 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Et0h Et0h deleted the tweak_config_gui branch May 1, 2019

albertosottile added a commit to albertosottile/syncplay that referenced this pull request May 1, 2019

Config dialog: Remove 'update list' button and tweak sizes (Syncplay#233
)

Also aligns executable input with other inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.