Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for OSX deploy issues #275

Merged
merged 28 commits into from Mar 22, 2020
Merged

Conversation

@palfrey
Copy link
Contributor

palfrey commented Mar 14, 2020

Deploys appear to be failing due to an issue with Travis installing it's dpl gem. Others (https://travis-ci.community/t/ruby-openssl-python-deployment-fails-on-osx-image/6753) have had the same problem, and this is a workaround from there that should probably work but is hard to check until it's on master.

@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Mar 14, 2020

The homebrew change is to make the Travis build work again, as without that for some reason python3 buildPy2app.py py2app fails to find python3 (also it makes the build a lot faster!)

@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Mar 14, 2020

The homebrew change is to make the Travis build work again, as without that for some reason python3 buildPy2app.py py2app fails to find python3 (also it makes the build a lot faster!)

I think that'll actually mean we don't need the workaround anymore actually, as we're not upgrading openssl anymore.

@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Mar 14, 2020

Thanks for your contribution. The brew update step has been removed and added several times to fix issues with the Travis build... Let's try without it, for a while.

I have two questions though:

  • Why is the Travis build for this PR not shown on GitHub?
  • From the build log (get from Travis) it seems that the build took place on 10.13, but it should use 10.12... Why did the build not run on Sierra, despite the image was correctly configured? Also, it seems the OS is not really recognized in the Travis interface.

I have no idea on how to fix these two issues. I would try to put os: osx in the macOS part of our matrix, as apparently that is required now (https://docs.travis-ci.com/user/reference/osx/).

@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Mar 14, 2020

* Why is the Travis build for this PR not shown on GitHub?

Probably because of the "branch only master" filtering I've now removed.

* From the build log ([get from Travis](https://travis-ci.org/github/Syncplay/syncplay/jobs/662405988#L748)) it seems that the build took place on 10.13, but it should use 10.12... Why did the build not run on Sierra, despite the image was correctly configured?  Also, it seems the OS is not really recognized in the Travis interface.

I have no idea on how to fix these two issues. I would try to put os: osx in the macOS part of
our matrix, as apparently that is required now (https://docs.travis-ci.com/user/reference/osx/).

Looks like this was due to the lack of the os:osx bit as you thought.

palfrey added 4 commits Mar 14, 2020
@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Mar 14, 2020

Thanks for your contribution. The brew update step has been removed and added several times to fix issues with the Travis build... Let's try without it, for a while.

Turns out once you lock it back down to 10.12, it's needed! Will keep prodding away at this and @ you once I've got a proper fix.

@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Mar 15, 2020

@albertosottile Right, I've managed to get it building properly again, and while using specific locked down URLs to Homebrew installs so we a) don't need an explicit upgrade b) have lower odds of breaking in the future when Homebrew updates things again...

@palfrey palfrey changed the title Workaround for OSX deploy issues Fixes for OSX deploy issues Mar 20, 2020
@Et0h Et0h requested a review from albertosottile Mar 22, 2020
@albertosottile

This comment has been minimized.

Copy link
Member

albertosottile commented Mar 22, 2020

This is great, thanks for going through the hassle of finding the URLs for the right homebrew formulas. Thank you for your contribution.

@albertosottile albertosottile merged commit 2a8de52 into Syncplay:master Mar 22, 2020
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@palfrey palfrey deleted the palfrey:fix-osx-deploy branch Mar 22, 2020
@palfrey

This comment has been minimized.

Copy link
Contributor Author

palfrey commented Mar 22, 2020

This is great, thanks for going through the hassle of finding the URLs for the right homebrew formulas. Thank you for your contribution.

Annoyingly, it turns out that the original fix is no longer needed (and was fiddly to test on non-master, so I hadn't checked before). #279 I think resets this and should now correct the problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.