Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ruby reinstall workaround for openssl, as not needed #279

Merged
merged 1 commit into from Mar 22, 2020

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Mar 22, 2020

So it turns out the workaround hack in #275 isn't needed any more, probably due to the homebrew changes there restricting the alterations to the filesystem. https://travis-ci.org/github/palfrey/syncplay/jobs/665559940 demos a upload being done, and other than it failing due to authorisation issues (which hopefully are just due to it being on my fork, not the main repo) it should hopefully work now!

@albertosottile
Copy link
Member

@albertosottile albertosottile commented Mar 22, 2020

Just saw this MR, I was about to try this myself. Let's see if that is the right call. Thanks for the fast fix!

@albertosottile albertosottile merged commit 3c27341 into Syncplay:master Mar 22, 2020
2 checks passed
@palfrey palfrey deleted the ruby-reinstall branch Mar 22, 2020
@palfrey
Copy link
Contributor Author

@palfrey palfrey commented Mar 22, 2020

Just saw this MR, I was about to try this myself. Let's see if that is the right call. Thanks for the fast fix!

Looks like the build passed, so LGTM. Thanks for the tool! It's been useful to me at the past, and so I figured I'd try and fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants