Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I corrected some not transltated on pt-BR and added pt-PT #317

Merged
merged 10 commits into from Jun 18, 2020
Merged

I corrected some not transltated on pt-BR and added pt-PT #317

merged 10 commits into from Jun 18, 2020

Conversation

artur309
Copy link
Contributor

@artur309 artur309 commented May 31, 2020

I corrected some not translated on pt-BR.

I added the pt-PT language since it changed the way the phrases and some words pt-BR does.

@artur309 artur309 changed the title I corrected some not transltated on pt-BR I corrected some not transltated on pt-BR and added pt-PT May 31, 2020
@Et0h
Copy link
Contributor

Et0h commented Jun 2, 2020

Thank you for your work on this. It isn't ready to be merged yet because if you look at https://ci.appveyor.com/project/Et0h/syncplay-88efr/builds/33227583 then you will see that the compilation of the NSIS script failed.

I am not 100% sure why, but I checked my NSIS folder and it does not contain PortuguesePT.nlf but it does contain Portuguese.nlf so the issue might be the filename cited needs changing.

It might also be the case that LANG_PORTUGUESEPT needs to just be LANG_PORTUGUESE, but I'm not 100% sure.

@artur309
Copy link
Contributor Author

artur309 commented Jun 2, 2020

Thank you for your work on this. It isn't ready to be merged yet because if you look at https://ci.appveyor.com/project/Et0h/syncplay-88efr/builds/33227583 then you will see that the compilation of the NSIS script failed.

I am not 100% sure why, but I checked my NSIS folder and it does not contain PortuguesePT.nlf but it does contain Portuguese.nlf so the issue might be the filename cited needs changing.

It might also be the case that LANG_PORTUGUESEPT needs to just be LANG_PORTUGUESE, but I'm not 100% sure.

Alright I will try see to

artur309 and others added 3 commits Jun 2, 2020
This fixes compatibility issues with Debian Buster and Ubuntu Eoan.
* Script for building deb package on Travis

* Adding deb build to Travis CI configuration

* Remove superflous install step from deb build

* Add permissions to execute build script for deb package.

* Update deb build environment to use Ubuntu 18.04

* Install the deb package as part of build process

* Fix deb location for installation test

* Remove installation test

Latest Ubuntu available on Travis doesn't meet minimum required version of pyside2.

* Fix pyside dependencies to make them more accurate.

* Switch deb build to Ubuntu 20.04

* Add installation and runtime test.

* Fix location of deb package for upload to bintray.

* Separate out testing from build script.

* Make the script output visible in Travis CI logs.

* Fix permissons for test script.
@Et0h
Copy link
Contributor

Et0h commented Jun 3, 2020

Just checked and it now gives the error VIAddVersionKey: "/LANG=${LANG_PORTUGUESEPT}" is not a valid language code!

To solve this you need to update buildPy2exe.exe to replace all references of ${LANG_PORTUGUESEPT} to ${LANG_PORTUGUESE}

@artur309
Copy link
Contributor Author

artur309 commented Jun 3, 2020

Just checked and it now gives the error VIAddVersionKey: "/LANG=${LANG_PORTUGUESEPT}" is not a valid language code!

To solve this you need to update buildPy2exe.exe to replace all references of ${LANG_PORTUGUESEPT} to ${LANG_PORTUGUESE}

Ok, thanks for bug reporting. I will try do that.

@artur309
Copy link
Contributor Author

artur309 commented Jun 4, 2020

It's done it have passed all checks :)

@Et0h Et0h merged commit a1a5d7b into Syncplay:master Jun 18, 2020
2 checks passed
@AtilioA
Copy link
Contributor

AtilioA commented Aug 6, 2020

@Et0h Maybe hello-arguments-error shouldn't be included in the translation files altogether?

@Et0h
Copy link
Contributor

Et0h commented Aug 7, 2020

@Et0h Maybe hello-arguments-error shouldn't be included in the translation files altogether?

Could do, although then I'd need to add extra code to avoid a build warning for a lack of a translation message.

albertosottile pushed a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
* Solved some errors on translation

* more error on translation founded

* Full portuguese from Portugal translation.

Since its the original country, I decided to change words. The way that Brazil writes its very different from Portugal
albertosottile pushed a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
albertosottile pushed a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
* Solved some errors on translation

* more error on translation founded

* Full portuguese from Portugal translation.

Since its the original country, I decided to change words. The way that Brazil writes its very different from Portugal
albertosottile pushed a commit to albertosottile/syncplay that referenced this issue Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants