Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turkish language translations added #364

Merged
merged 2 commits into from
Nov 29, 2020
Merged

Turkish language translations added #364

merged 2 commits into from
Nov 29, 2020

Conversation

muaz742
Copy link
Contributor

@muaz742 muaz742 commented Nov 3, 2020

I could not understand how to add language option to the project codes. But I translated messages to Turkish from English.

@Et0h
Copy link
Contributor

Et0h commented Nov 23, 2020

Thank you for your work on this.

See 1daea64 for an example of what it looks like to add a translation.

I can do most of it, but the main thing missing is the changes to buildPy2exe.py to add Turkish messages to the installer.

I need translations for the following messages translated into Turkish (you can tell me them in the Pull Request and I can do the coding side of it):

  LangString ^Associate $${LANG_TURKISH} "Associate Syncplay with multimedia files."
  LangString ^Shortcut $${LANG_TURKISH} "Create Shortcuts in following locations:"
  LangString ^StartMenu $${LANG_TURKISH} "Start Menu"
  LangString ^Desktop $${LANG_TURKISH} "Desktop"
  LangString ^QuickLaunchBar $${LANG_TURKISH} "Quick Launch Bar"
  LangString ^AutomaticUpdates $${LANG_TURKISH} "Check for updates automatically"
  LangString ^UninstConfig $${LANG_TURKISH} "Delete configuration file."

  Push 'Turkish'

* Repaired variable name in to message_tr.py

* Added new 'tr' language to 'language-argument'

* Added Turkish translation in buildPy2exe.py
@muaz742
Copy link
Contributor Author

muaz742 commented Nov 29, 2020

Thank you for explaining.

I reviewed the commit and worked according to the commit. I hope benefit.

@Et0h
Copy link
Contributor

Et0h commented Nov 29, 2020

Thank you. I will need to review it but it looks good.

@Et0h
Copy link
Contributor

Et0h commented Nov 29, 2020

Checked and the PR is fine to merge but two post-merge tweaks are needed:

  1. Make the 'start menu' checkbox in the installer slightly wider so that it fits the message.
  2. Update messages to add reference to the new IINA support recently added in Add support for IINA player #360

I also noticed that the order of most of the languages are different in the installer and in Syncplay itself, so I might want to tweak Syncplay to use the same alphabetical order as the installer.

@Et0h Et0h merged commit cd52e18 into Syncplay:master Nov 29, 2020
@Et0h
Copy link
Contributor

Et0h commented Nov 29, 2020

I've done those changes:

  1. Widen Windows installer start menu checkbox for Turkish translation: 628a233
  2. Update Turkish translation for IINA: 2923fad
  3. Make language list alphabetical for consistency: 1644eec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants