Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move python_mpv_jsonipc in our vendor folder #369

Merged
merged 2 commits into from Dec 4, 2020
Merged

Move python_mpv_jsonipc in our vendor folder #369

merged 2 commits into from Dec 4, 2020

Conversation

albertosottile
Copy link
Member

We embed a copy ofpython_mpv_jsonipc (https://github.com/iwalton3/python-mpv-jsonipc) in our package to control mpv and IINA. Since this is external code, it would be better to relocate it in the vendor folder that we already have in out package, for this purpose.

Copy link
Contributor

@Et0h Et0h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this change. Tested it, and it works fine for me on Windows (including when I build an installer and run Syncplay from that).

@Et0h Et0h merged commit 86241b0 into master Dec 4, 2020
@Et0h Et0h deleted the mpv_ipc_vendor branch December 4, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants