Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added French Translation #455

Merged
merged 10 commits into from
Dec 21, 2021
Merged

Added French Translation #455

merged 10 commits into from
Dec 21, 2021

Conversation

sosie-js
Copy link
Contributor

@sosie-js sosie-js commented Aug 12, 2021

The rabbit has produced the french translation file for the Gui with the private tool (messages_en.py -> messages2ass.py -> fastrad -> ass2messages.py -> messages_fr.py ) and the doc.

@Et0h
Copy link
Contributor

Et0h commented Aug 14, 2021

Hi, thanks for providing a French translation of Syncplay.

I note that you have a translation into French for the main Syncplay application, but not for the installer. See https://github.com/Syncplay/syncplay/pull/364/files for the Turkish translation pull request as it is a good example of the changes to buildPy2exe.py and other files.

The pull request should contain just the translations into French.

In terms of changes to the translation system (e.g. to use .ass files), this is completely separate from the French translation itself and should not be in the pull request.

In terms of documentation files for translations, this is not something we do. Attribution is given through commit messages and this is then used to inform https://syncplay.pl/about/development/ and https://syncplay.pl/changelog/

@sosie-js
Copy link
Contributor Author

sosie-js commented Aug 15, 2021

Oh I wondered what was buildPy2exe.py for. Okay using .ass was the sugar for others who don't want spend ages
to translate your stuff or stay in sync with translations for the future. I will remove it for the french translation pull request and make an other project from it.

In terms of documentation files for translations, this is not something we do. Attribution is given through commit >messages and this is then used to inform https://syncplay.pl/about/development/ and https://syncplay.pl/changelog/

Yout mean the pdf here? I was generated by hand with libreoffice but I think this could be automated.

@sosie-js sosie-js changed the title French touch Added French Translation Aug 15, 2021
@Et0h
Copy link
Contributor

Et0h commented Aug 18, 2021

Yout mean the pdf here?

Yes - we don't have documentation within Syncplay to tell people what a translation looks like. It is useful to know that you have tested the translation and it works, but it should be removed from the PR to be in line with other translation PRs.

@sosie-js
Copy link
Contributor Author

sosie-js commented Aug 19, 2021

Yes - we don't have documentation within Syncplay to tell people what a translation looks like. It is useful to
know that you have tested the translation and it works, but it should be removed from the PR to be in line with
other translation PRs.

Ok I remove it, my goal was not I to force people of others translation to do so but having a good overview of Gui at least in English should have promote this project and those who translate as the same time(end page of 4) using the odt as basis.

@sosie-js sosie-js closed this Aug 19, 2021
@sosie-js
Copy link
Contributor Author

For merge

@sosie-js sosie-js reopened this Aug 19, 2021
@Et0h
Copy link
Contributor

Et0h commented Oct 17, 2021

Hi @sosie-js and sorry about the lateness of my reply - I finally have a day when I'm free to go through the various PRs and issues that have built up.

I've reviewed your PR and it looks almost ready for merge, but it needs one final tweak: syncplay/messages_fr.py has messages at the beginning, which isn't something which we have for the other translations. If those can be removed then I think it's ready for merging. Thanks again for your work on this translation.

@sosie-js
Copy link
Contributor Author

sosie-js commented Dec 20, 2021

I will have a look asap

@sosie-js
Copy link
Contributor Author

Should match your requirement now.

@Et0h Et0h merged commit 842ac9e into Syncplay:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants