Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print timestamp when pausing. #521

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Print timestamp when pausing. #521

merged 4 commits into from
Apr 7, 2022

Conversation

Kansattica
Copy link
Contributor

I would like to use Syncplay to watch a movie with a friend for a podcast where we watch together, pause to talk about things, and assemble it into a slide slow later. Syncplay printing when the media was paused in its log would help with this immensely.

@Et0h
Copy link
Contributor

Et0h commented Apr 6, 2022

This seems like a good idea to me - a small tweak that makes the notification more useful. I tested the code and it works for me.

I'd be interested in people's thoughts on whether the proposed format of "Bob paused (00:05)" is better than going with "Bob paused at 00:05". The latter is more in line with the format for "Bob jumped from 14:04 to 12:56" format used elsewhere and avoids conflict with "(MM:SS)" being the format used to display the duration when announcing "Bob is playing 'Example.mkv' (23:40) in room: 'Videos'".

It could still use () for other languages for now as that doesn't require a translation, but we could add something to the stub that they should consider tweaking it to follow the English format.

@Kansattica
Copy link
Contributor Author

I originally wrote "Bob paused at 00:05" and changed it to the other phrasing because I didn't have the expertise to translate it into the other languages. If it's preferable to have a complete sentence for English and leave the others as stubs for now, I'm happy to make the change.

@Et0h Et0h merged commit 2ef8570 into Syncplay:master Apr 7, 2022
@Et0h
Copy link
Contributor

Et0h commented Apr 7, 2022

It's a simple tweak so I'm happy to make the change myself now that I've confirmed you are happy with the wording.

Et0h added a commit that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants