New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change type, of file in ConfigurationGetter.py from str to utf-8 #85

Merged
merged 1 commit into from Dec 15, 2015

Conversation

Projects
None yet
2 participants
@abhsag24
Contributor

abhsag24 commented Dec 14, 2015

changed the type, of file in argparser so that files can accept unicode characters

@Et0h

This comment has been minimized.

Show comment
Hide comment
@Et0h

Et0h Dec 15, 2015

Contributor

Tested in Windows and it doesn't seem to break anything. Unicode for file path arguments in Windows is already broken (due to how Python gets the arguments), so people have to open Syncplay then the file if they want to open Unicode files.

Contributor

Et0h commented Dec 15, 2015

Tested in Windows and it doesn't seem to break anything. Unicode for file path arguments in Windows is already broken (due to how Python gets the arguments), so people have to open Syncplay then the file if they want to open Unicode files.

Et0h added a commit that referenced this pull request Dec 15, 2015

Merge pull request #85 from abhsag24/master
Fix non-Windows Unicode file path argument bug

@Et0h Et0h merged commit 5fc49a1 into Syncplay:master Dec 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment